Fix test_runner.py hang on pdfium_test error
The subprocess.check_call() invocation in test_runner.TestText() can
throw an exception if pdfium_test returns an error. This prevents
TestOneFileParallel() from returning a valid result tuple, which causes
the multiprocessing pool to get stuck.
R=dhoss@chromium.org
Change-Id: I363aa301e13d9ff6bdc44c8f1d4bc48bb453f502
Bug: pdfium:1670
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79070
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
diff --git a/testing/tools/test_runner.py b/testing/tools/test_runner.py
index 91c67fc..4a34938 100644
--- a/testing/tools/test_runner.py
+++ b/testing/tools/test_runner.py
@@ -205,7 +205,10 @@
cmd_to_run.append('--disable-xfa')
cmd_to_run.append(pdf_path)
- subprocess.check_call(cmd_to_run, stdout=outfile)
+ try:
+ subprocess.check_call(cmd_to_run, stdout=outfile)
+ except subprocess.CalledProcessError as e:
+ return e
# If the expected file does not exist, the output is expected to be empty.
if not os.path.exists(expected_txt_path):
