commit 603dcd8c116df8c00c69755d87ef28dc9584f134
author Hui Yingst <nigi@chromium.org> Mon Nov 09 22:36:46 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Nov 09 22:36:46 2020 +0000
tree 591a50cc93dd42a93394d24a327769cd97ae5ba2
parent 5e4a5a467caa13460b3585de228dab1fd4468154

Enable FPDFAnnotEmbedderTest.BUG_1206 for Skia/SkiaPaths.

With Skia/SkiaPaths enabled, the rendering result for
FPDFAnnotEmbedderTest.BUG_1206 has small discrepancies compared to AGG's
expected result. These discrepancies are caused by Skia's own way of
hairline handling which happens when the scale of rectangles are
relatively small.

Since the discrepancies are not very visible and the Skia/SkiaPaths
rendering results are considered acceptable, this CL updates the
Skia/SkiaPaths expectation for this test so that it can pass.

Bug: pdfium:1500
Change-Id: I8692d0469186d1a8b779f13810cdba6c53221805
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/76070
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>

fpdfsdk/fpdf_annot_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_annot_embeddertest.cpp b/fpdfsdk/fpdf_annot_embeddertest.cpp
index 2cb76c0..89e38e7 100644
--- a/fpdfsdk/fpdf_annot_embeddertest.cpp
+++ b/fpdfsdk/fpdf_annot_embeddertest.cpp
@@ -1985,15 +1985,13 @@
   UnloadPage(page);
 }
 
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
+TEST_F(FPDFAnnotEmbedderTest, BUG_1206) {
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-#define MAYBE_BUG_1206 DISABLED_BUG_1206
+  static const char kExpectedBitmap[] = "a1ea1ceebb26922fae576cb79ce63af0";
 #else
-#define MAYBE_BUG_1206 BUG_1206
-#endif
-TEST_F(FPDFAnnotEmbedderTest, MAYBE_BUG_1206) {
-  static constexpr size_t kExpectedSize = 1609;
   static const char kExpectedBitmap[] = "0d9fc05c6762fd788bd23fd87a4967bc";
+#endif
+  static constexpr size_t kExpectedSize = 1609;
 
   ASSERT_TRUE(OpenDocument("bug_1206.pdf"));