commit 6677044a60731d6ad10b8c7bb4a7808e0927cf23
author Tom Sepez <tsepez@chromium.org> Mon May 17 17:36:09 2021 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon May 17 17:36:09 2021 +0000
tree 9e32f229b4904ae36c15967da2fe4c9ee46d9d11
parent 866eb53fd1245d01366a3e11809e7ee98f2739fe

Stop overloading CPDF_BAFontMap::EncodeFontAlias().

The only caller of the second form is the first form, so we
can simplify here.

Change-Id: Ie88c78ae2fcdd2ebd0b7c9af5206194c843cf55e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/80450
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfdoc/cpdf_bafontmap.cpp

diff --git a/core/fpdfdoc/cpdf_bafontmap.cpp b/core/fpdfdoc/cpdf_bafontmap.cpp
index e6d08b1..2fbc390 100644
--- a/core/fpdfdoc/cpdf_bafontmap.cpp
+++ b/core/fpdfdoc/cpdf_bafontmap.cpp
@@ -356,12 +356,9 @@
 
 ByteString CPDF_BAFontMap::EncodeFontAlias(const ByteString& sFontName,
                                            int32_t nCharset) {
-  return EncodeFontAlias(sFontName) + ByteString::Format("_%02X", nCharset);
-}
-
-ByteString CPDF_BAFontMap::EncodeFontAlias(const ByteString& sFontName) {
   ByteString sRet = sFontName;
   sRet.Remove(' ');
+  sRet += ByteString::Format("_%02X", nCharset);
   return sRet;
 }
 

core/fpdfdoc/cpdf_bafontmap.h

diff --git a/core/fpdfdoc/cpdf_bafontmap.h b/core/fpdfdoc/cpdf_bafontmap.h
index 9aa8c43..c28bce0 100644
--- a/core/fpdfdoc/cpdf_bafontmap.h
+++ b/core/fpdfdoc/cpdf_bafontmap.h
@@ -71,7 +71,6 @@
                       int32_t nCharset);
 
   ByteString EncodeFontAlias(const ByteString& sFontName, int32_t nCharset);
-  ByteString EncodeFontAlias(const ByteString& sFontName);
 
   int32_t FindFont(const ByteString& sFontName, int32_t nCharset);
   ByteString GetNativeFontName(int32_t nCharset);