commit 67993b4c4e71fec3cce05420e458e89089147002
author Lei Zhang <thestig@chromium.org> Mon Nov 28 21:53:48 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Nov 28 21:53:48 2022 +0000
tree 7580865e0de1f2b3e614fe5abace7bbc604ae452
parent 46e0999af26a73f3cd00cc1a7046f7b4fc143081

Fix bad refactoring in RgbByteOrderTransferBitmap().

Fix an issue introduced in https://pdfium-review.googlesource.com/101610
where one branch never incremented the destination buffer pointer.

Bug: chromium:1386120
Change-Id: I188a5371852d968b3ba60c7150a225ea3a2c2dc9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101730
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxge/agg/fx_agg_driver.cpp

diff --git a/core/fxge/agg/fx_agg_driver.cpp b/core/fxge/agg/fx_agg_driver.cpp
index 9047e0d..88c99e1 100644
--- a/core/fxge/agg/fx_agg_driver.cpp
+++ b/core/fxge/agg/fx_agg_driver.cpp
@@ -168,13 +168,13 @@
           dest_scan += 4;
           src_scan += 4;
         }
-        continue;
-      }
-      for (int col = 0; col < width; col++) {
-        *dest_scan++ = src_scan[2];
-        *dest_scan++ = src_scan[1];
-        *dest_scan++ = src_scan[0];
-        src_scan += 3;
+      } else {
+        for (int col = 0; col < width; col++) {
+          *dest_scan++ = src_scan[2];
+          *dest_scan++ = src_scan[1];
+          *dest_scan++ = src_scan[0];
+          src_scan += 3;
+        }
       }
       dest_buf += dest_pitch;
     }