commit 6dceb53484b65aa73c2ebc25bbd83c59e1cd5b18
author Jochen Eisinger <jochen@chromium.org> Fri Jul 15 13:41:01 2016 +0200
committer Jochen Eisinger <jochen@chromium.org> Fri Jul 15 13:41:01 2016 +0200
tree 9c1e02947ee30a69a9d4af64388d3739e8556932
parent e5effaf2556046b01265484922e0b8681790323b

Remove constructor from functions that aren't constructors

BUG=chromium:625823
TBR=haraken@chromium.org,thestig@chromium.org

Review-Url: https://codereview.chromium.org/2128793002
(cherry picked from commit 3c27a84d15c06f85cc7f455f96dc124673f9f9d2)

Review URL: https://codereview.chromium.org/2153113002 .

DEPS

diff --git a/DEPS b/DEPS
index 32ae5ed..f75994c 100644
--- a/DEPS
+++ b/DEPS
@@ -14,8 +14,8 @@
   'icu_revision': 'c291cde264469b20ca969ce8832088acb21e0c48',
   'pdfium_tests_revision': '6c769320872e6ca82da4adaec1a497237f71b543',
   'skia_revision': '6f47dbaff54a7705ef3e98f1f65c765e56fd9bd0',
-  'trace_event_revision': 'd83d44b13d07c2fd0a40101a7deef9b93b841732',
-  'v8_revision': '5cd0d8f27e3f740179a8a3de7b9d2c0cfae7afb9',
+  'trace_event_revision': '54b8455be9505c2cb0cf5c26bb86739c236471aa',
+  'v8_revision': '453b746d88e3d047d3f6c4363f0fe42b6bd13638',
 }
 
 deps = {

build_gyp/standalone.gypi

diff --git a/build_gyp/standalone.gypi b/build_gyp/standalone.gypi
index f191c28..2b6ff6a 100644
--- a/build_gyp/standalone.gypi
+++ b/build_gyp/standalone.gypi
@@ -50,6 +50,7 @@
     'werror%': '-Werror',
     'v8_optimized_debug%': 0,
     'v8_use_external_startup_data%': 0,
+    'icu_use_data_file_flag%': 1,
     'icu_gyp_path': '../third_party/icu/icu.gyp',
     'libjpeg_gyp_path': '../third_party/third_party.gyp',
     'conditions': [

xfa/fxjse/dynprop.cpp

diff --git a/xfa/fxjse/dynprop.cpp b/xfa/fxjse/dynprop.cpp
index 498c660..2fa7a8d 100644
--- a/xfa/fxjse/dynprop.cpp
+++ b/xfa/fxjse/dynprop.cpp
@@ -63,9 +63,11 @@
           1, v8::String::NewFromUtf8(
                  pIsolate, reinterpret_cast<const char*>(szPropName.raw_str()),
                  v8::String::kNormalString, szPropName.GetLength()));
-      lpValue->ForceSetValue(v8::Function::New(
-          lpValue->GetIsolate(), FXJSE_DynPropGetterAdapter_MethodCallback,
-          hCallBackInfo));
+      lpValue->ForceSetValue(
+          v8::Function::New(lpValue->GetIsolate()->GetCurrentContext(),
+                            FXJSE_DynPropGetterAdapter_MethodCallback,
+                            hCallBackInfo, 0, v8::ConstructorBehavior::kThrow)
+              .ToLocalChecked());
     }
   }
 }