commit 6e3b41939d132fb2256ec9c767994f2a1d678bce
author Lei Zhang <thestig@chromium.org> Sat May 09 02:06:33 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Sat May 09 02:06:33 2020 +0000
tree 9483370ad1e9ebd6fc9e66d01a6bc73932048ca4
parent 127b5db066000f438799364788d60cb910fc7017

Add tests for FPDF_GetNamedDestByName() with old style destinations.

Show FPDF_GetNamedDestByName() cannot retrieve them.

Bug: chromium:1080663
Change-Id: I0479565650e35096f06dc21a02e5be9753742c4e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69752
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_view_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_view_embeddertest.cpp b/fpdfsdk/fpdf_view_embeddertest.cpp
index 81145f0..4ab89a0 100644
--- a/fpdfsdk/fpdf_view_embeddertest.cpp
+++ b/fpdfsdk/fpdf_view_embeddertest.cpp
@@ -690,6 +690,15 @@
 TEST_F(FPDFViewEmbedderTest, NamedDestsOldStyle) {
   EXPECT_TRUE(OpenDocument("named_dests_old_style.pdf"));
   EXPECT_EQ(2u, FPDF_CountNamedDests(document()));
+
+  // Test bad parameters.
+  EXPECT_FALSE(FPDF_GetNamedDestByName(document(), nullptr));
+  EXPECT_FALSE(FPDF_GetNamedDestByName(document(), ""));
+  EXPECT_FALSE(FPDF_GetNamedDestByName(document(), "NoSuchName"));
+
+  // TODO(crbug.com/1080663): These should return a valid destination.
+  EXPECT_FALSE(FPDF_GetNamedDestByName(document(), "FirstAlternate"));
+  EXPECT_FALSE(FPDF_GetNamedDestByName(document(), "LastAlternate"));
 }
 
 // The following tests pass if the document opens without crashing.