commit 83d0028e3cc61c5c9d3e64f5c7cc747df53b0f2b
author Lei Zhang <thestig@chromium.org> Wed Dec 14 19:06:04 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Dec 14 19:06:04 2022 +0000
tree 610d7dcca8473b53a11557943eb4b7b631b19386
parent 58858f7e12acbecd9b34b3df9435c6b2388b64cd

Remove unused agg::path_storage::add_path_curve().

After https://pdfium.googlesource.com/pdfium/+/eed57bffcd, this method
has no caller left. Delete it but do not add an AGG .patch file, as this
method was never part of AGG 2.3 in the first place. In turn, remove
some unused AGG curve code that also does not exist upstream.

Change-Id: Ibef65f5a745c2be8d29266058bf10d3a615687ea
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/102493
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

third_party/agg23/agg_curves.h

diff --git a/third_party/agg23/agg_curves.h b/third_party/agg23/agg_curves.h
index 908bd9a..205128a 100644
--- a/third_party/agg23/agg_curves.h
+++ b/third_party/agg23/agg_curves.h
@@ -107,21 +107,6 @@
         *y = p.y;
         return (m_count == 1) ? path_cmd_move_to : path_cmd_line_to;
     }
-    unsigned vertex_flag(float* x, float* y, int& flag)
-    {
-        if(m_count >= m_points.size()) {
-            return path_cmd_stop;
-        }
-        const point_type& p = m_points[m_count++];
-        *x = p.x;
-        *y = p.y;
-        flag = p.flag;
-        return (m_count == 1) ? path_cmd_move_to : path_cmd_line_to;
-    }
-    int count()
-    {
-        return m_points.size();
-    }
 private:
     void bezier(float x1, float y1,
                 float x2, float y2,
@@ -175,14 +160,6 @@
     {
         return m_curve_div.vertex(x, y);
     }
-    unsigned vertex_curve_flag(float* x, float* y, int& flag)
-    {
-        return m_curve_div.vertex_flag(x, y, flag);
-    }
-    int count()
-    {
-        return m_curve_div.count();
-    }
 private:
     curve4_div m_curve_div;
 };

third_party/agg23/agg_path_storage.h

diff --git a/third_party/agg23/agg_path_storage.h b/third_party/agg23/agg_path_storage.h
index 8c2bd36..8214806 100644
--- a/third_party/agg23/agg_path_storage.h
+++ b/third_party/agg23/agg_path_storage.h
@@ -76,22 +76,6 @@
             add_vertex(x, y, cmd);
         }
     }
-    template<class VertexSource>
-    void add_path_curve(VertexSource& vs,
-                        unsigned path_id = 0,
-                        bool solid_path = true)
-    {
-        float x, y;
-        unsigned cmd;
-        int flag;
-        vs.rewind(path_id);
-        while(!is_stop(cmd = vs.vertex_curve_flag(&x, &y, flag))) {
-            if(is_move_to(cmd) && solid_path && m_total_vertices) {
-                cmd = path_cmd_line_to | flag;
-            }
-            add_vertex(x, y, cmd | flag);
-        }
-    }
     unsigned total_vertices() const
     {
         return m_total_vertices;