commit 84be8f91c0d57a6bb962d913593f9a4abce873c9
author Lei Zhang <thestig@chromium.org> Fri Dec 16 23:17:47 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Dec 16 23:17:47 2022 +0000
tree 3d85f93f42cd013586f0c1ede118229729f71a7f
parent 07ba7027c243a0a187e76955c6154f89489a98e5

Mark CFX_ScanlineCompositor::Composite* methods as const.

They only manipulate their arguments and do not change
CFX_ScanlineCompositor state.

Change-Id: Ia36cd9d6d8f0bb2f6c983918977b95ece27e7696
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/102734
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxge/dib/cfx_scanlinecompositor.cpp

diff --git a/core/fxge/dib/cfx_scanlinecompositor.cpp b/core/fxge/dib/cfx_scanlinecompositor.cpp
index 64b2621..cfdc237 100644
--- a/core/fxge/dib/cfx_scanlinecompositor.cpp
+++ b/core/fxge/dib/cfx_scanlinecompositor.cpp
@@ -2318,7 +2318,7 @@
     pdfium::span<uint8_t> dest_scan,
     pdfium::span<const uint8_t> src_scan,
     int width,
-    pdfium::span<const uint8_t> clip_scan) {
+    pdfium::span<const uint8_t> clip_scan) const {
   DCHECK(m_SrcFormat == FXDIB_Format::kRgb ||
          m_SrcFormat == FXDIB_Format::kRgb32 ||
          m_SrcFormat == FXDIB_Format::kArgb);
@@ -2467,7 +2467,7 @@
     pdfium::span<const uint8_t> src_scan,
     int src_left,
     int width,
-    pdfium::span<const uint8_t> clip_scan) {
+    pdfium::span<const uint8_t> clip_scan) const {
   DCHECK(m_SrcFormat == FXDIB_Format::k1bppRgb ||
          m_SrcFormat == FXDIB_Format::k8bppRgb);
 
@@ -2558,7 +2558,7 @@
     pdfium::span<uint8_t> dest_scan,
     pdfium::span<const uint8_t> src_scan,
     int width,
-    pdfium::span<const uint8_t> clip_scan) {
+    pdfium::span<const uint8_t> clip_scan) const {
   if (m_DestFormat == FXDIB_Format::k8bppMask) {
     CompositeRow_ByteMask2Mask(dest_scan, src_scan, m_MaskAlpha, width,
                                clip_scan);
@@ -2609,7 +2609,7 @@
     pdfium::span<const uint8_t> src_scan,
     int src_left,
     int width,
-    pdfium::span<const uint8_t> clip_scan) {
+    pdfium::span<const uint8_t> clip_scan) const {
   if (m_DestFormat == FXDIB_Format::k8bppMask) {
     CompositeRow_BitMask2Mask(dest_scan, src_scan, m_MaskAlpha, src_left, width,
                               clip_scan);

core/fxge/dib/cfx_scanlinecompositor.h

diff --git a/core/fxge/dib/cfx_scanlinecompositor.h b/core/fxge/dib/cfx_scanlinecompositor.h
index a44e04c..9fa6a86 100644
--- a/core/fxge/dib/cfx_scanlinecompositor.h
+++ b/core/fxge/dib/cfx_scanlinecompositor.h
@@ -29,24 +29,24 @@
   void CompositeRgbBitmapLine(pdfium::span<uint8_t> dest_scan,
                               pdfium::span<const uint8_t> src_scan,
                               int width,
-                              pdfium::span<const uint8_t> clip_scan);
+                              pdfium::span<const uint8_t> clip_scan) const;
 
   void CompositePalBitmapLine(pdfium::span<uint8_t> dest_scan,
                               pdfium::span<const uint8_t> src_scan,
                               int src_left,
                               int width,
-                              pdfium::span<const uint8_t> clip_scan);
+                              pdfium::span<const uint8_t> clip_scan) const;
 
   void CompositeByteMaskLine(pdfium::span<uint8_t> dest_scan,
                              pdfium::span<const uint8_t> src_scan,
                              int width,
-                             pdfium::span<const uint8_t> clip_scan);
+                             pdfium::span<const uint8_t> clip_scan) const;
 
   void CompositeBitMaskLine(pdfium::span<uint8_t> dest_scan,
                             pdfium::span<const uint8_t> src_scan,
                             int src_left,
                             int width,
-                            pdfium::span<const uint8_t> clip_scan);
+                            pdfium::span<const uint8_t> clip_scan) const;
 
  private:
   class Palette {