commit 8867d042d59a0d211c3e71e9ba4ec646d9e813a0
author Tom Sepez <tsepez@chromium.org> Fri Mar 20 15:46:24 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Mar 20 15:46:24 2020 +0000
tree 4db504d8472d91a6dce1f8cc4f29dfd03163975a
parent a250c670efbe433786f06b9d9e4ca039fc0279bc

Use more helper functions in CFXJSE_Value

Change-Id: Ia565df9b896b1ab7e6b78aac10f1f6cee227e5b8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67550
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fxjs/xfa/cfxjse_value.cpp

diff --git a/fxjs/xfa/cfxjse_value.cpp b/fxjs/xfa/cfxjse_value.cpp
index 97551e5..6479b4a 100644
--- a/fxjs/xfa/cfxjse_value.cpp
+++ b/fxjs/xfa/cfxjse_value.cpp
@@ -121,8 +121,8 @@
 
 void CFXJSE_Value::SetFloat(float fFloat) {
   CFXJSE_ScopeUtil_IsolateHandle scope(GetIsolate());
-  v8::Local<v8::Value> pValue = v8::Number::New(GetIsolate(), ftod(fFloat));
-  m_hValue.Reset(GetIsolate(), pValue);
+  m_hValue.Reset(GetIsolate(),
+                 fxv8::NewNumberHelper(GetIsolate(), ftod(fFloat)));
 }
 
 bool CFXJSE_Value::SetObjectProperty(ByteStringView szPropName,
@@ -396,36 +396,30 @@
 
 void CFXJSE_Value::SetUndefined() {
   CFXJSE_ScopeUtil_IsolateHandle scope(GetIsolate());
-  v8::Local<v8::Value> hValue = v8::Undefined(GetIsolate());
-  m_hValue.Reset(GetIsolate(), hValue);
+  m_hValue.Reset(GetIsolate(), fxv8::NewUndefinedHelper(GetIsolate()));
 }
 
 void CFXJSE_Value::SetNull() {
   CFXJSE_ScopeUtil_IsolateHandle scope(GetIsolate());
-  v8::Local<v8::Value> hValue = v8::Null(GetIsolate());
-  m_hValue.Reset(GetIsolate(), hValue);
+  m_hValue.Reset(GetIsolate(), fxv8::NewNullHelper(GetIsolate()));
 }
 
 void CFXJSE_Value::SetBoolean(bool bBoolean) {
   CFXJSE_ScopeUtil_IsolateHandle scope(GetIsolate());
-  v8::Local<v8::Value> hValue = v8::Boolean::New(GetIsolate(), !!bBoolean);
-  m_hValue.Reset(GetIsolate(), hValue);
+  m_hValue.Reset(GetIsolate(), fxv8::NewBooleanHelper(GetIsolate(), bBoolean));
 }
 
 void CFXJSE_Value::SetInteger(int32_t nInteger) {
   CFXJSE_ScopeUtil_IsolateHandle scope(GetIsolate());
-  v8::Local<v8::Value> hValue = v8::Integer::New(GetIsolate(), nInteger);
-  m_hValue.Reset(GetIsolate(), hValue);
+  m_hValue.Reset(GetIsolate(), fxv8::NewNumberHelper(GetIsolate(), nInteger));
 }
 
 void CFXJSE_Value::SetDouble(double dDouble) {
   CFXJSE_ScopeUtil_IsolateHandle scope(GetIsolate());
-  v8::Local<v8::Value> hValue = v8::Number::New(GetIsolate(), dDouble);
-  m_hValue.Reset(GetIsolate(), hValue);
+  m_hValue.Reset(GetIsolate(), fxv8::NewNumberHelper(GetIsolate(), dDouble));
 }
 
 void CFXJSE_Value::SetString(ByteStringView szString) {
   CFXJSE_ScopeUtil_IsolateHandle scope(GetIsolate());
-  v8::Local<v8::Value> hValue = fxv8::NewStringHelper(GetIsolate(), szString);
-  m_hValue.Reset(GetIsolate(), hValue);
+  m_hValue.Reset(GetIsolate(), fxv8::NewStringHelper(GetIsolate(), szString));
 }