commit 89f5c5561b3b1767d641b7e626f4028ac9b60eb1
author Lei Zhang <thestig@chromium.org> Fri Mar 27 22:34:38 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Mar 27 22:34:38 2020 +0000
tree 4dc7a9c4abe76d686c95790ab9be5b282d06bb2b
parent c1037d5c3bf91604ca8f0caa10dfe448bfcac855

Check FPDFDoc_AddAttachment() results in FPDFAttachmentEmbedderTest.

Change-Id: I497b032b000911bfe89105da810d10a5059c920a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67931
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_attachment_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_attachment_embeddertest.cpp b/fpdfsdk/fpdf_attachment_embeddertest.cpp
index 7ce6003..aee00a9 100644
--- a/fpdfsdk/fpdf_attachment_embeddertest.cpp
+++ b/fpdfsdk/fpdf_attachment_embeddertest.cpp
@@ -99,6 +99,7 @@
   ScopedFPDFWideString file_name = GetFPDFWideString(L"0.txt");
   FPDF_ATTACHMENT attachment =
       FPDFDoc_AddAttachment(document(), file_name.get());
+  ASSERT_TRUE(attachment);
 
   // Check that writing to a file with nullptr but non-zero bytes would fail.
   EXPECT_FALSE(FPDFAttachment_SetFile(attachment, document(), nullptr, 10));
@@ -127,6 +128,7 @@
   // Add an attachment to the end of the embedded file list and set its file.
   file_name = GetFPDFWideString(L"z.txt");
   attachment = FPDFDoc_AddAttachment(document(), file_name.get());
+  ASSERT_TRUE(attachment);
   constexpr char kContents2[] = "World!";
   EXPECT_TRUE(FPDFAttachment_SetFile(attachment, document(), kContents2,
                                      strlen(kContents2)));
@@ -159,6 +161,7 @@
   ScopedFPDFWideString file_name = GetFPDFWideString(L"5.txt");
   FPDF_ATTACHMENT attachment =
       FPDFDoc_AddAttachment(document(), file_name.get());
+  ASSERT_TRUE(attachment);
   constexpr char kContents[] = "Hello World!";
   EXPECT_TRUE(FPDFAttachment_SetFile(attachment, document(), kContents,
                                      strlen(kContents)));
@@ -230,6 +233,7 @@
 
   // Verify the name of the first attachment.
   FPDF_ATTACHMENT attachment = FPDFDoc_GetAttachment(document(), 0);
+  ASSERT_TRUE(attachment);
   unsigned long length_bytes = FPDFAttachment_GetName(attachment, nullptr, 0);
   ASSERT_EQ(12u, length_bytes);
   std::vector<FPDF_WCHAR> buf = GetFPDFWideStringBuffer(length_bytes);
@@ -242,6 +246,7 @@
 
   // Verify the name of the new first attachment.
   attachment = FPDFDoc_GetAttachment(document(), 0);
+  ASSERT_TRUE(attachment);
   length_bytes = FPDFAttachment_GetName(attachment, nullptr, 0);
   ASSERT_EQ(26u, length_bytes);
   buf = GetFPDFWideStringBuffer(length_bytes);