Replace empty span checks with ASSERTs in CCodec_JpegModule.
Callers, e.g. CPDF_DIBBase::Load(), already check to make sure the data
is not empty before attempting to create decoders.
Change-Id: I7ad3cf60c4ac82c529d63c6a6cd8969750453bd9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/55751
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/core/fxcodec/codec/ccodec_jpegmodule.cpp b/core/fxcodec/codec/ccodec_jpegmodule.cpp
index 9da6585..0310c95 100644
--- a/core/fxcodec/codec/ccodec_jpegmodule.cpp
+++ b/core/fxcodec/codec/ccodec_jpegmodule.cpp
@@ -54,8 +54,7 @@
static pdfium::span<const uint8_t> JpegScanSOI(
pdfium::span<const uint8_t> src_span) {
- if (src_span.empty())
- return {};
+ ASSERT(!src_span.empty());
for (size_t offset = 0; offset < src_span.size() - 1; ++offset) {
if (src_span[offset] == 0xff && src_span[offset + 1] == 0xd8)
@@ -407,8 +406,7 @@
int height,
int nComps,
bool ColorTransform) {
- if (src_span.empty())
- return nullptr;
+ ASSERT(!src_span.empty());
auto pDecoder = pdfium::MakeUnique<CCodec_JpegDecoder>();
if (!pDecoder->Create(src_span, width, height, nComps, ColorTransform))
