[Skia] Remove `SHOW_TEXT_GLYPHS`
Since Skia no longer provides public APIs to convert glyphs to their
equivalent unichars, we can no longer use `SHOW_TEXT_GLYPHS` option
to print the unichars for debugging. This CL removes `SHOW_TEXT_GLYPHS`
and the code guarded by it.
Bug: pdfium:1791
Change-Id: I0bbc223036e41fd03a9306e28a1a2b9a38face10
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93394
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nigi <nigi@chromium.org>
diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp
index 97e50b5..275bc55 100644
--- a/core/fxge/skia/fx_skia_device.cpp
+++ b/core/fxge/skia/fx_skia_device.cpp
@@ -183,7 +183,6 @@
#define SHOW_SKIA_PATH_SHORTHAND 0 // set to 1 for abbreviated path contents
#endif
#define DRAW_SKIA_CLIP 0 // set to 1 to draw a green rectangle around the clip
-#define SHOW_TEXT_GLYPHS 0 // set to 1 to print unichar equivalent of glyph
#if SHOW_SKIA_PATH
void DebugShowSkiaPaint(const SkPaint& paint) {
@@ -1031,17 +1030,6 @@
#if defined(_SKIA_SUPPORT_PATHS_)
m_pDriver->PreMultiply();
#endif
-#if SHOW_TEXT_GLYPHS
- SkTDArray<SkUnichar> text;
- // TODO(nigi): |m_glyphs| are deprecated and glyphToUnichars() takes 4
- // parameters now.
- text.setCount(m_glyphs.count());
- skPaint.glyphsToUnichars(m_glyphs.begin(), m_glyphs.count(), text.begin());
- for (int i = 0; i < m_glyphs.count(); ++i)
- printf("%lc", m_glyphs[i]);
- printf("\n");
-#endif
-
if (m_rsxform.count()) {
sk_sp<SkTextBlob> blob = SkTextBlob::MakeFromRSXform(
glyphs.begin(), glyphs.bytes(), m_rsxform.begin(), font,
@@ -1792,14 +1780,6 @@
}
if (oneAtATime)
useRSXform = false;
-#if SHOW_TEXT_GLYPHS
- SkTDArray<SkUnichar> text;
- text.setCount(glyphs.count());
- paint.glyphsToUnichars(glyphs.begin(), glyphs.count(), text.begin());
- for (int i = 0; i < glyphs.count(); ++i)
- printf("%lc", text[i]);
- printf("\n");
-#endif
#if defined(_SKIA_SUPPORT_PATHS_)
m_pBitmap->PreMultiply();
#endif
