commit 8dc00cb084be282e659ab89d2f5469a511f557bd
author Tom Sepez <tsepez@chromium.org> Fri Aug 05 20:24:22 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 05 20:24:22 2022 +0000
tree d61f0ee67fb39143e74ddde8fac1f9005c9fa153
parent 51115e5055ff32bfb4447ad15f68f536480429df

Pass retained image to CPDF_ImageObject::SetImage()

Turns out all callers are already passing rvalues, so no other
modifications needed.

Change-Id: I856e84fdb1bd33f8c38b0e1e227d87b5ea24fd58
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/95770
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/page/cpdf_imageobject.cpp

diff --git a/core/fpdfapi/page/cpdf_imageobject.cpp b/core/fpdfapi/page/cpdf_imageobject.cpp
index 345092c..0633ed1 100644
--- a/core/fpdfapi/page/cpdf_imageobject.cpp
+++ b/core/fpdfapi/page/cpdf_imageobject.cpp
@@ -6,6 +6,8 @@
 
 #include "core/fpdfapi/page/cpdf_imageobject.h"
 
+#include <utility>
+
 #include "core/fpdfapi/page/cpdf_docpagedata.h"
 #include "core/fpdfapi/page/cpdf_image.h"
 #include "core/fpdfapi/parser/cpdf_stream.h"
@@ -50,9 +52,9 @@
   SetRect(m_Matrix.TransformRect(kRect));
 }
 
-void CPDF_ImageObject::SetImage(const RetainPtr<CPDF_Image>& pImage) {
+void CPDF_ImageObject::SetImage(RetainPtr<CPDF_Image> pImage) {
   MaybePurgeCache();
-  m_pImage = pImage;
+  m_pImage = std::move(pImage);
 }
 
 RetainPtr<CPDF_Image> CPDF_ImageObject::GetImage() const {

core/fpdfapi/page/cpdf_imageobject.h

diff --git a/core/fpdfapi/page/cpdf_imageobject.h b/core/fpdfapi/page/cpdf_imageobject.h
index 5e0ee4b..af18da4 100644
--- a/core/fpdfapi/page/cpdf_imageobject.h
+++ b/core/fpdfapi/page/cpdf_imageobject.h
@@ -28,7 +28,7 @@
   const CPDF_ImageObject* AsImage() const override;
 
   void CalcBoundingBox();
-  void SetImage(const RetainPtr<CPDF_Image>& pImage);
+  void SetImage(RetainPtr<CPDF_Image> pImage);
   RetainPtr<CPDF_Image> GetImage() const;
   RetainPtr<CFX_DIBitmap> GetIndependentBitmap() const;