commit 8f7325b7290c7601a9cba6587fc10286702b7207
author Lei Zhang <thestig@chromium.org> Mon Jun 28 22:04:15 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 28 22:04:15 2021 +0000
tree 7df5e6227759b30477f1127bd06187d9dabd63ca
parent b58dff03e5939de9857f21ce5a18719838ac140d

Improve test coverage for FPDFPageObj_GetDashArray().

Test one combination of parameters that no existing code exercises.

Change-Id: Ic046ba608d15b607e7b5a4a657db00c40bffa9dc
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/82591
Reviewed-by: Hui Yingst <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_editpage_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_editpage_embeddertest.cpp b/fpdfsdk/fpdf_editpage_embeddertest.cpp
index e18c23e..2af4e54 100644
--- a/fpdfsdk/fpdf_editpage_embeddertest.cpp
+++ b/fpdfsdk/fpdf_editpage_embeddertest.cpp
@@ -268,6 +268,11 @@
     EXPECT_FLOAT_EQ(5.0f, phase);
     ASSERT_EQ(3, FPDFPageObj_GetDashCount(path));
 
+    // Pretend `get_array` has too few members.
+    EXPECT_FALSE(FPDFPageObj_GetDashArray(path, get_array, 2));
+    for (int i = 0; i < 4; i++)
+      EXPECT_FLOAT_EQ(-1.0f, get_array[i]);
+
     ASSERT_TRUE(FPDFPageObj_GetDashArray(path, get_array, 4));
 
     // `get_array` should be modified only up to dash_count