Add comment to string_view_template.h about pass-by-value
Change-Id: I8230ed204e0cd10480326a0c0bd655b59d056bfd
Reviewed-on: https://pdfium-review.googlesource.com/c/47310
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/core/fxcrt/string_view_template.h b/core/fxcrt/string_view_template.h
index adedbdc..6cf80db 100644
--- a/core/fxcrt/string_view_template.h
+++ b/core/fxcrt/string_view_template.h
@@ -22,6 +22,9 @@
// An immutable string with caller-provided storage which must outlive the
// string itself. These are not necessarily nul-terminated, so that substring
// extraction (via the Mid(), Left(), and Right() methods) is copy-free.
+//
+// String view arguments should be passed by value, since they are small,
+// rather than const-ref, even if they are not modified.
template <typename T>
class StringViewTemplate {
public:
