commit 94d30b216b23f0a67d6838810afe194cfc50d392
author Andrew Weintraub <asweintraub@google.com> Fri Jan 13 00:50:51 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jan 13 00:50:51 2023 +0000
tree 419d7c1ae09f05269887f3e34845b24277cf142d
parent 911cbc385437b7671891b33b711635dee6ce99d2

Resolves the following technical debt issue:

return type 'const CharType' (aka 'const T') is 'const'-qualified at the
top level, which may reduce code readability without improving const
correctness (3 more occurrences)

PiperOrigin-RevId: 501661122
Change-Id: I45486b148755ede2f4459137822a58a1106785ec
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103251
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andrew Weintraub <asweintraub@google.com>

core/fxcrt/string_view_template.h

diff --git a/core/fxcrt/string_view_template.h b/core/fxcrt/string_view_template.h
index d98a124..168e3eb 100644
--- a/core/fxcrt/string_view_template.h
+++ b/core/fxcrt/string_view_template.h
@@ -181,7 +181,7 @@
     return !m_Span.empty() ? m_Span[m_Span.size() - 1] : 0;
   }
 
-  const CharType CharAt(const size_t index) const {
+  CharType CharAt(const size_t index) const {
     return static_cast<CharType>(m_Span[index]);
   }