commit 96ef1dd84d1d288f7eeb05ce97d19871e912bf64
author Dan Sinclair <dsinclair@chromium.org> Wed Oct 25 15:44:14 2017 -0400
committer Chromium commit bot <commit-bot@chromium.org> Wed Oct 25 21:04:27 2017 +0000
tree 834ec62819abca2256295695071d05b132678068
parent 6687f780d0c7a9a4f453f166bb4efb55294349a6

Remove unused CJS_Object methods

The methods are unused, Removed.

Change-Id: Icce60103bf0cc9364f3d5cc7c3032e959b9ffa09
Reviewed-on: https://pdfium-review.googlesource.com/16831
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

fpdfsdk/javascript/JS_Object.cpp

diff --git a/fpdfsdk/javascript/JS_Object.cpp b/fpdfsdk/javascript/JS_Object.cpp
index cd86889..01a4641 100644
--- a/fpdfsdk/javascript/JS_Object.cpp
+++ b/fpdfsdk/javascript/JS_Object.cpp
@@ -14,18 +14,6 @@
 CJS_EmbedObj::~CJS_EmbedObj() {
 }
 
-void FreeObject(const v8::WeakCallbackInfo<CJS_Object>& data) {
-  CJS_Object* pJSObj = data.GetParameter();
-  delete pJSObj;
-  CFXJS_Engine::FreeObjectPrivate(data.GetInternalField(0));
-}
-
-void DisposeObject(const v8::WeakCallbackInfo<CJS_Object>& data) {
-  CJS_Object* pJSObj = data.GetParameter();
-  pJSObj->Dispose();
-  data.SetSecondPassCallback(FreeObject);
-}
-
 CJS_Object::CJS_Object(v8::Local<v8::Object> pObject) {
   m_pIsolate = pObject->GetIsolate();
   m_pV8Object.Reset(m_pIsolate, pObject);
@@ -33,13 +21,4 @@
 
 CJS_Object::~CJS_Object() {}
 
-void CJS_Object::MakeWeak() {
-  m_pV8Object.SetWeak(this, DisposeObject,
-                      v8::WeakCallbackType::kInternalFields);
-}
-
-void CJS_Object::Dispose() {
-  m_pV8Object.Reset();
-}
-
 void CJS_Object::InitInstance(IJS_Runtime* pIRuntime) {}

fpdfsdk/javascript/JS_Object.h

diff --git a/fpdfsdk/javascript/JS_Object.h b/fpdfsdk/javascript/JS_Object.h
index 293b98a..e0a96a9 100644
--- a/fpdfsdk/javascript/JS_Object.h
+++ b/fpdfsdk/javascript/JS_Object.h
@@ -34,9 +34,6 @@
   explicit CJS_Object(v8::Local<v8::Object> pObject);
   virtual ~CJS_Object();
 
-  void MakeWeak();
-  void Dispose();
-
   virtual void InitInstance(IJS_Runtime* pIRuntime);
 
   v8::Local<v8::Object> ToV8Object() { return m_pV8Object.Get(m_pIsolate); }