commit 9a2012c6e1527a6ef8d6dedc62e8e48bde259871
author Tom Sepez <tsepez@chromium.org> Thu Apr 15 18:52:56 2021 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Apr 15 18:52:56 2021 +0000
tree 1b62fadadfd3d159af0a7bc11a0145735e25d258
parent beab570f793ed75e192490d4fa8eeeab75874725

Remove CPDFXFA_DocEnvironment::NotifySubmit()

Far simpler to split it up and move to only callers.

Change-Id: Id6c7ac8cff36e5d0ca6c53fb42eb5b75674b53a3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79531
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp

diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
index c6d9513..76dbc33 100644
--- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
+++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp
@@ -629,12 +629,12 @@
 
 #ifdef PDF_XFA_ELEMENT_SUBMIT_ENABLED
 bool CPDFXFA_DocEnvironment::Submit(CXFA_FFDoc* hDoc, CXFA_Submit* submit) {
-  if (!NotifySubmit(true) || !m_pContext->GetXFADocView())
+  if (!OnBeforeNotifySubmit() || !m_pContext->GetXFADocView())
     return false;
 
   m_pContext->GetXFADocView()->UpdateDocView();
   bool ret = SubmitInternal(hDoc, submit);
-  NotifySubmit(false);
+  OnAfterNotifySubmit();
   return ret;
 }
 
@@ -887,14 +887,6 @@
   m_pContext->GetXFADocView()->UpdateDocView();
 }
 
-bool CPDFXFA_DocEnvironment::NotifySubmit(bool bPrevOrPost) {
-  if (bPrevOrPost)
-    return OnBeforeNotifySubmit();
-
-  OnAfterNotifySubmit();
-  return true;
-}
-
 bool CPDFXFA_DocEnvironment::SubmitInternal(CXFA_FFDoc* hDoc,
                                             CXFA_Submit* submit) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv = m_pContext->GetFormFillEnv();

fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h

diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h
index 0a8b366..f6789bc 100644
--- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h
+++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h
@@ -80,7 +80,6 @@
   void ToXFAContentFlags(WideString csSrcContent, FPDF_DWORD& flag);
   bool OnBeforeNotifySubmit();
   void OnAfterNotifySubmit();
-  bool NotifySubmit(bool bPrevOrPost);
   bool SubmitInternal(CXFA_FFDoc* hDoc, CXFA_Submit* submit);
 #endif  // PDF_XFA_ELEMENT_SUBMIT_ENABLED