commit 9bad23500e4aa1f167ae03b469c06b2f317e873a
author Lei Zhang <thestig@chromium.org> Thu Jun 28 13:29:33 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Jun 28 13:29:33 2018 +0000
tree df3d6cd8a0da74646344149f4965fb94ac8758bb
parent 774c90d5ec92d2c58d821c445230d8cb71928dcb

Replace DCHECKs with ASSERTs.

Change-Id: I0f2bf1cb44b4cba872a719f0a75d8776f413812c
Reviewed-on: https://pdfium-review.googlesource.com/36250
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

core/fpdfapi/parser/cpdf_document.cpp

diff --git a/core/fpdfapi/parser/cpdf_document.cpp b/core/fpdfapi/parser/cpdf_document.cpp
index 91c6b9c..4f69913 100644
--- a/core/fpdfapi/parser/cpdf_document.cpp
+++ b/core/fpdfapi/parser/cpdf_document.cpp
@@ -248,7 +248,7 @@
   }
 
   m_PageList.resize(linearized_header->GetPageCount());
-  DCHECK(linearized_header->GetFirstPageNo() < m_PageList.size());
+  ASSERT(linearized_header->GetFirstPageNo() < m_PageList.size());
   m_PageList[linearized_header->GetFirstPageNo()] =
       linearized_header->GetFirstPageObjNum();
 }
@@ -326,7 +326,7 @@
 }
 
 void CPDF_Document::SetParser(std::unique_ptr<CPDF_Parser> pParser) {
-  DCHECK(!m_pParser);
+  ASSERT(!m_pParser);
   m_pParser = std::move(pParser);
 }
 

core/fpdfapi/parser/cpdf_object_stream.cpp

diff --git a/core/fpdfapi/parser/cpdf_object_stream.cpp b/core/fpdfapi/parser/cpdf_object_stream.cpp
index 779fbff..2d0bd99 100644
--- a/core/fpdfapi/parser/cpdf_object_stream.cpp
+++ b/core/fpdfapi/parser/cpdf_object_stream.cpp
@@ -60,7 +60,7 @@
 CPDF_ObjectStream::CPDF_ObjectStream(const CPDF_Stream* obj_stream)
     : obj_num_(obj_stream->GetObjNum()),
       first_object_offset_(obj_stream->GetDict()->GetIntegerFor("First")) {
-  DCHECK(IsObjectsStreamObject(obj_stream));
+  ASSERT(IsObjectsStreamObject(obj_stream));
   if (const auto* extends_ref =
           ToReference(obj_stream->GetDict()->GetObjectFor("Extends"))) {
     extends_obj_num_ = extends_ref->GetRefObjNum();

fxjs/cjs_global.cpp

diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp
index e9b2a4b..6396aa7 100644
--- a/fxjs/cjs_global.cpp
+++ b/fxjs/cjs_global.cpp
@@ -143,7 +143,7 @@
 void CJS_Global::queryprop_static(
     v8::Local<v8::Name> property,
     const v8::PropertyCallbackInfo<v8::Integer>& info) {
-  DCHECK(property->IsString());
+  ASSERT(property->IsString());
   JSSpecialPropQuery<CJS_Global>(
       "global",
       v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),
@@ -154,7 +154,7 @@
 void CJS_Global::getprop_static(
     v8::Local<v8::Name> property,
     const v8::PropertyCallbackInfo<v8::Value>& info) {
-  DCHECK(property->IsString());
+  ASSERT(property->IsString());
   JSSpecialPropGet<CJS_Global>(
       "global",
       v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),
@@ -166,7 +166,7 @@
     v8::Local<v8::Name> property,
     v8::Local<v8::Value> value,
     const v8::PropertyCallbackInfo<v8::Value>& info) {
-  DCHECK(property->IsString());
+  ASSERT(property->IsString());
   JSSpecialPropPut<CJS_Global>(
       "global",
       v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),
@@ -177,7 +177,7 @@
 void CJS_Global::delprop_static(
     v8::Local<v8::Name> property,
     const v8::PropertyCallbackInfo<v8::Boolean>& info) {
-  DCHECK(property->IsString());
+  ASSERT(property->IsString());
   JSSpecialPropDel<CJS_Global>(
       "global",
       v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),