commit 9c950b158ab08a20835a7db77f55be27b4299804
author Lei Zhang <thestig@chromium.org> Wed Jan 16 19:06:37 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Jan 16 19:06:37 2019 +0000
tree f9b1ddd76e4d0bc398c257915dca69d782fe8f16
parent f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a

Improve LoadCIDType0Font test to check dictionary entry types.

Bug: pdfium:1224
Change-Id: I8af042ff0286932a3d5e50843fde07c1e9cb0d27
Reviewed-on: https://pdfium-review.googlesource.com/c/48390
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_edit_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index 89c69bf..24a6234 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -2244,8 +2244,16 @@
   const CPDF_Dictionary* cidinfo_dict =
       cidfont_dict->GetDictFor("CIDSystemInfo");
   ASSERT_TRUE(cidinfo_dict);
-  EXPECT_EQ("Adobe", cidinfo_dict->GetStringFor("Registry"));
-  EXPECT_EQ("Identity", cidinfo_dict->GetStringFor("Ordering"));
+  // TODO(https://crbug.com/pdfium/1224): These two dictionary values should be
+  // strings, not names.
+  const CPDF_Object* registry = cidinfo_dict->GetObjectFor("Registry");
+  ASSERT_TRUE(registry);
+  EXPECT_EQ(CPDF_Object::kName, registry->GetType());
+  EXPECT_EQ("Adobe", registry->GetString());
+  const CPDF_Object* ordering = cidinfo_dict->GetObjectFor("Ordering");
+  ASSERT_TRUE(ordering);
+  EXPECT_EQ(CPDF_Object::kName, ordering->GetType());
+  EXPECT_EQ("Identity", ordering->GetString());
   EXPECT_EQ(0, cidinfo_dict->GetNumberFor("Supplement"));
   CheckFontDescriptor(cidfont_dict, FPDF_FONT_TYPE1, false, false, span);