Remove dead SetFontStyle from CBC_OneCode and CBC_OneDimWriter Remove SetFontStyle and the backing font_style_ member variable from CBC_OneCode and CBC_OneDimWriter. font_style_ was initialized to 0 and never read in any rendering or calculation, and SetFontStyle was never exposed on CFX_Barcode or called anywhere in PDFium. Change-Id: Ic5c35ba59cd346a9ffa4c84cf51922027eabbafc Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/163670 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/fxbarcode/cbc_onecode.cpp b/fxbarcode/cbc_onecode.cpp index f5e5ef0..b59a13c 100644 --- a/fxbarcode/cbc_onecode.cpp +++ b/fxbarcode/cbc_onecode.cpp
@@ -50,10 +50,6 @@ GetOneDimWriter()->SetFontSize(size); } -void CBC_OneCode::SetFontStyle(int32_t style) { - GetOneDimWriter()->SetFontStyle(style); -} - void CBC_OneCode::SetFontColor(FX_ARGB color) { GetOneDimWriter()->SetFontColor(color); }
diff --git a/fxbarcode/cbc_onecode.h b/fxbarcode/cbc_onecode.h index 1eb313f..1ddc48f 100644 --- a/fxbarcode/cbc_onecode.h +++ b/fxbarcode/cbc_onecode.h
@@ -27,7 +27,6 @@ void SetCalChecksum(bool calc); bool SetFont(CFX_Font* cFont); void SetFontSize(float size); - void SetFontStyle(int32_t style); void SetFontColor(FX_ARGB color); private:
diff --git a/fxbarcode/oned/BC_OneDimWriter.cpp b/fxbarcode/oned/BC_OneDimWriter.cpp index 3b59b11..1f99886 100644 --- a/fxbarcode/oned/BC_OneDimWriter.cpp +++ b/fxbarcode/oned/BC_OneDimWriter.cpp
@@ -77,10 +77,6 @@ font_size_ = size; } -void CBC_OneDimWriter::SetFontStyle(int32_t style) { - font_style_ = style; -} - void CBC_OneDimWriter::SetFontColor(FX_ARGB color) { font_color_ = color; }
diff --git a/fxbarcode/oned/BC_OneDimWriter.h b/fxbarcode/oned/BC_OneDimWriter.h index 7228005..509af9f 100644 --- a/fxbarcode/oned/BC_OneDimWriter.h +++ b/fxbarcode/oned/BC_OneDimWriter.h
@@ -45,7 +45,6 @@ void SetPrintChecksum(bool checksum); void SetCalcChecksum(bool state); void SetFontSize(float size); - void SetFontStyle(int32_t style); void SetFontColor(FX_ARGB color); virtual DataVector<uint8_t> Encode(const ByteString& contents) = 0; @@ -84,7 +83,6 @@ UnownedPtr<CFX_Font> font_; float font_size_ = 10.0f; - int32_t font_style_ = 0; uint32_t font_color_ = 0xff000000; BC_TEXT_LOC loc_text_loc_ = BC_TEXT_LOC::kBelowEmbed;