commit a5d951a4920017799e5ef07d2b98064b84bf7998
author Lei Zhang <thestig@chromium.org> Wed Apr 08 19:45:30 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Apr 08 19:45:30 2020 +0000
tree f27bf3417e123f9441c506198d9c1a85465a74a3
parent 26f88e68ab73b08fdf0c639f16d13dc26bb932c0

Add FPDFFormFillEmbedderTest.KeyPressWithNoFocusedAnnot.

Fill a small gap in test coverage from
https://pdfium-review.googlesource.com/65810.

Change-Id: I02604068805a7b5cf1605eaafb3ecc2215066056
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68510
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_formfill_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_formfill_embeddertest.cpp b/fpdfsdk/fpdf_formfill_embeddertest.cpp
index d9c33fe..df8ccfc 100644
--- a/fpdfsdk/fpdf_formfill_embeddertest.cpp
+++ b/fpdfsdk/fpdf_formfill_embeddertest.cpp
@@ -836,6 +836,36 @@
   UnloadPage(page);
 }
 
+TEST_F(FPDFFormFillEmbedderTest, KeyPressWithNoFocusedAnnot) {
+  ASSERT_TRUE(OpenDocument("annotiter.pdf"));
+  FPDF_PAGE page = LoadPage(0);
+  ASSERT_TRUE(page);
+
+  // There should be no focused annotation to start with.
+  int page_index = -2;
+  FPDF_ANNOTATION annot = nullptr;
+  EXPECT_TRUE(FORM_GetFocusedAnnot(form_handle(), &page_index, &annot));
+  EXPECT_EQ(-1, page_index);
+  EXPECT_FALSE(annot);
+
+  static constexpr int kKeysToPress[] = {
+      FWL_VKEY_NewLine, FWL_VKEY_Return, FWL_VKEY_Space,
+      FWL_VKEY_Delete,  FWL_VKEY_0,      FWL_VKEY_9,
+      FWL_VKEY_A,       FWL_VKEY_Z,      FWL_VKEY_F1,
+  };
+  for (int key : kKeysToPress) {
+    // Pressing random keys when there is no focus should not trigger focus.
+    EXPECT_FALSE(FORM_OnKeyDown(form_handle(), page, key, 0));
+    page_index = -2;
+    annot = nullptr;
+    EXPECT_TRUE(FORM_GetFocusedAnnot(form_handle(), &page_index, &annot));
+    EXPECT_EQ(-1, page_index);
+    EXPECT_FALSE(annot);
+  }
+
+  UnloadPage(page);
+}
+
 #ifdef PDF_ENABLE_XFA
 TEST_F(FPDFFormFillEmbedderTest, XFAFormFillFirstTab) {
   EXPECT_TRUE(OpenDocument("xfa/email_recommended.pdf"));
@@ -2893,4 +2923,4 @@
   // TODO(crbug.com/1028991): Following should be changed to ASSERT_TRUE after
   // handling key press implementation on buttons.
   ASSERT_FALSE(FORM_OnChar(form_handle(), page(), FWL_VKEY_Return, 0));
-}
\ No newline at end of file
+}