commit a6f1534790e3e00c21a50befbe14f976311fc94c
author Lei Zhang <thestig@chromium.org> Fri Mar 20 20:35:08 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Mar 20 20:35:08 2020 +0000
tree 230f636fd6411bf12dcfebfd5a57a91982d5f5f7
parent bf198e71ef2872cc8cb21e58c85c252643085168

Properly create test page objects in CPDF_Document's unit tests.

Page objects must have /Type /Page in their dictionaries. /Page is a
name and not a string. In cpdf_document_unittest.cpp, change how the
/Type entry is created in CreatePageTreeNode() CreateNumberedPage(), so
/Page has the correct object type.

Change-Id: I3d595a8241ac033d5820b7c1e0b9573c611c74d2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67599
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/parser/cpdf_document_unittest.cpp

diff --git a/core/fpdfapi/parser/cpdf_document_unittest.cpp b/core/fpdfapi/parser/cpdf_document_unittest.cpp
index a3f7c53..3a4c4b1 100644
--- a/core/fpdfapi/parser/cpdf_document_unittest.cpp
+++ b/core/fpdfapi/parser/cpdf_document_unittest.cpp
@@ -31,7 +31,7 @@
                                     int count) {
   CPDF_Array* pUnowned = pDoc->AddIndirectObject(std::move(kids))->AsArray();
   CPDF_Dictionary* pageNode = pDoc->NewIndirect<CPDF_Dictionary>();
-  pageNode->SetNewFor<CPDF_String>("Type", "Pages", false);
+  pageNode->SetNewFor<CPDF_Name>("Type", "Pages");
   pageNode->SetNewFor<CPDF_Reference>("Kids", pDoc, pUnowned->GetObjNum());
   pageNode->SetNewFor<CPDF_Number>("Count", count);
   for (size_t i = 0; i < pUnowned->size(); i++) {
@@ -43,7 +43,7 @@
 
 RetainPtr<CPDF_Dictionary> CreateNumberedPage(size_t number) {
   auto page = pdfium::MakeRetain<CPDF_Dictionary>();
-  page->SetNewFor<CPDF_String>("Type", "Page", false);
+  page->SetNewFor<CPDF_Name>("Type", "Page");
   page->SetNewFor<CPDF_Number>("PageNumbering", static_cast<int>(number));
   return page;
 }