Remove code after abort() for -Wunreachable-code.
The code was added in https://codereview.chromium.org/1128043009/
It was then later ifdef'd out on Windows to enable its unreachable
code warning c4702.
Now that we want to turn this warning on with other compilers,
remove the code completely.
abort() is marked noreturn in headers. It's possible to
install a SIGABRT handler, but it's not allowed to return,
so it can't be used to make abort() return -- see `man abort`.
Bug: chromium:346399
Change-Id: I05b01a8424a66c6609f16af47e40698e9f7e376e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67410
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/core/fxcrt/fx_memory.cpp b/core/fxcrt/fx_memory.cpp
index 1ed4949..ca99926 100644
--- a/core/fxcrt/fx_memory.cpp
+++ b/core/fxcrt/fx_memory.cpp
@@ -67,11 +67,8 @@
static int make_this_function_aliased = 0xbd;
pdfium::base::debug::Alias(&make_this_function_aliased);
- // Termimate cleanly if we can, else crash at a specific address (0xbd).
+ // Termimate cleanly.
abort();
-#if !defined(OS_WIN)
- reinterpret_cast<void (*)()>(0xbd)();
-#endif
}
void* FX_SafeAlloc(size_t num_members, size_t member_size) {
