commit acb1b1785acff88c5ea825b76d6fac2ab5e66102
author Hui Yingst <nigi@chromium.org> Thu Sep 03 23:47:01 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Sep 03 23:47:01 2020 +0000
tree e24d6637fb7bc3e8b834f6499201a94c04b4dfc7
parent c7de3423c9fdd474aa5aa5599601439110691a66

Enable FPDFFlattenEmbedderTest.BUG_889099 for Skia/SkiaPaths.

When Skia/SkiaPaths is enabled, FPDFFlattenEmbedderTest.BUG_889099 fails
due to Skia's own way of hairline handling along the edges of a
rectangle. Since the discrepancy between AGG's and Skia's rendering
results is not obvious to human eyes and it goes away as the scale of
rendering goes up, we consider Skia's rendering result acceptable.

This CL adds the expected checksum for using Skia/SkiaPaths so that the
test can pass.

Bug: pdfium:1500
Change-Id: If6129849a34a0048d295eb216df3f69fb6634b2e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/73334
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

fpdfsdk/fpdf_flatten_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_flatten_embeddertest.cpp b/fpdfsdk/fpdf_flatten_embeddertest.cpp
index dd0d5c9..a0b7ff9 100644
--- a/fpdfsdk/fpdf_flatten_embeddertest.cpp
+++ b/fpdfsdk/fpdf_flatten_embeddertest.cpp
@@ -98,27 +98,25 @@
   VerifySavedDocument(300, 400, kFlattenedPageHash);
 }
 
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
+TEST_F(FPDFFlattenEmbedderTest, BUG_890322) {
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-#define MAYBE_BUG_890322 DISABLED_BUG_890322
+  constexpr char kChecksum[] = "793689536cf64fe792c2f241888c0cf3";
 #else
-#define MAYBE_BUG_890322 BUG_890322
+  constexpr char kChecksum[] = "6c674642154408e877d88c6c082d67e9";
 #endif
-TEST_F(FPDFFlattenEmbedderTest, MAYBE_BUG_890322) {
-  constexpr char md5_hash[] = "6c674642154408e877d88c6c082d67e9";
   ASSERT_TRUE(OpenDocument("bug_890322.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
 
   ScopedFPDFBitmap bitmap = RenderLoadedPageWithFlags(page, FPDF_ANNOT);
-  CompareBitmap(bitmap.get(), 200, 200, md5_hash);
+  CompareBitmap(bitmap.get(), 200, 200, kChecksum);
 
   EXPECT_EQ(FLATTEN_SUCCESS, FPDFPage_Flatten(page, FLAT_PRINT));
   EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
 
   UnloadPage(page);
 
-  VerifySavedDocument(200, 200, md5_hash);
+  VerifySavedDocument(200, 200, kChecksum);
 }
 
 // TODO(crbug.com/pdfium/11): Fix this test and enable.