commit af616af067fece263b1f1bd421902c9114f1029f
author Tom Sepez <tsepez@chromium.org> Fri Nov 04 22:40:42 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Nov 04 22:40:42 2022 +0000
tree 83ec66f4eb3308abea358eb11cc5db752eb3de18
parent 5b5987975af1d5155c1f4c84aa4a9d9d46cc5ec2

Use retained local in CPDF_StructTree::LoadPageTree()

It is safer, and skirts yet another spurious clang-analyzer warning.

Change-Id: I46a181a428f398c8f67c1a2f7cc38ad2b36467e8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/100678
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfdoc/cpdf_structtree.cpp

diff --git a/core/fpdfdoc/cpdf_structtree.cpp b/core/fpdfdoc/cpdf_structtree.cpp
index 912f301..67ac948 100644
--- a/core/fpdfdoc/cpdf_structtree.cpp
+++ b/core/fpdfdoc/cpdf_structtree.cpp
@@ -84,7 +84,8 @@
   if (parents_id < 0)
     return;
 
-  const CPDF_Array* pParentArray = ToArray(parent_tree.LookupValue(parents_id));
+  RetainPtr<const CPDF_Array> pParentArray =
+      ToArray(parent_tree.LookupValue(parents_id));
   if (!pParentArray)
     return;