Update imports in coverage_report.py.
After pdfium_root.py got added, coverage_report.py no longer works as
is. Update its sys.path to include //testing/tools instead of the root
source dir, so imports work correctly again.
Change-Id: Ib17df58d9a88ede9f279f1cce5db21e7be619928
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101310
Reviewed-by: K. Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/testing/tools/coverage/coverage_report.py b/testing/tools/coverage/coverage_report.py
index 171fe65..a4b1765 100755
--- a/testing/tools/coverage/coverage_report.py
+++ b/testing/tools/coverage/coverage_report.py
@@ -16,14 +16,11 @@
import subprocess
import sys
-# Add src dir to path to avoid having to set PYTHONPATH.
+# Add parent dir to avoid having to set PYTHONPATH.
sys.path.append(
- os.path.abspath(
- os.path.join(
- os.path.dirname(__file__), os.path.pardir, os.path.pardir,
- os.path.pardir)))
+ os.path.abspath(os.path.join(os.path.dirname(__file__), os.path.pardir)))
-from testing.tools.common import GetBooleanGnArg
+import common
# 'binary' is the file that is to be run for the test.
# 'use_test_runner' indicates if 'binary' depends on test_runner.py and thus
@@ -91,14 +88,14 @@
'No valid tests in set to be run. This is likely due to bad command '
'line arguments')
- if not GetBooleanGnArg('use_clang_coverage', self.build_directory,
- self.verbose):
+ if not common.GetBooleanGnArg('use_clang_coverage', self.build_directory,
+ self.verbose):
parser.error(
'use_clang_coverage does not appear to be set to true for build, but '
'is needed')
- self.use_goma = GetBooleanGnArg('use_goma', self.build_directory,
- self.verbose)
+ self.use_goma = common.GetBooleanGnArg('use_goma', self.build_directory,
+ self.verbose)
self.output_directory = args['output_directory']
if not os.path.exists(self.output_directory):
