commit bb9aa5ef755e118dcf62a94253f5ba2f4626e57c
author Tom Sepez <tsepez@chromium.org> Thu Jan 09 23:34:17 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Jan 09 23:34:17 2020 +0000
tree a92a9bd3a2939126d4d444cdf4e53b0efe0b56ac
parent c2564692a16b9d3bdf4a681dbf8c102c528ee7b2

Remove two impossible null-argument checks in CPDFSDK_PageView.

AddAnnot() and DeleteAnnot() only have one caller each, and they
have already checked for nullness.

Change-Id: I68dec7645d69e91930f637c010d831b35d1b6e86
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/64910
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_pageview.cpp

diff --git a/fpdfsdk/cpdfsdk_pageview.cpp b/fpdfsdk/cpdfsdk_pageview.cpp
index 32d8a90..6b5f21d 100644
--- a/fpdfsdk/cpdfsdk_pageview.cpp
+++ b/fpdfsdk/cpdfsdk_pageview.cpp
@@ -123,9 +123,6 @@
 
 #ifdef PDF_ENABLE_XFA
 CPDFSDK_Annot* CPDFSDK_PageView::AddAnnot(CXFA_FFWidget* pPDFAnnot) {
-  if (!pPDFAnnot)
-    return nullptr;
-
   CPDFSDK_Annot* pSDKAnnot = GetAnnotByXFAWidget(pPDFAnnot);
   if (pSDKAnnot)
     return pSDKAnnot;
@@ -142,9 +139,6 @@
 }
 
 bool CPDFSDK_PageView::DeleteAnnot(CPDFSDK_Annot* pAnnot) {
-  if (!pAnnot)
-    return false;
-
   IPDF_Page* pPage = pAnnot->GetXFAPage();
   if (!pPage)
     return false;