commit beab570f793ed75e192490d4fa8eeeab75874725
author Tom Sepez <tsepez@chromium.org> Thu Apr 15 18:27:56 2021 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Apr 15 18:27:56 2021 +0000
tree fe4e1f98d2aedeb67dd698db80aec8a8c61f31b4
parent 6b712766e73646b6072146345fb2c5f2ba0fdaae

Remove always-false argument to CPDFSDK_InteractiveForm::SubmitForm()

Change-Id: I3c78ee9ad7501784310212dff42179406b33b924
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79530
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_interactiveform.cpp

diff --git a/fpdfsdk/cpdfsdk_interactiveform.cpp b/fpdfsdk/cpdfsdk_interactiveform.cpp
index 36a2189..47c2f28 100644
--- a/fpdfsdk/cpdfsdk_interactiveform.cpp
+++ b/fpdfsdk/cpdfsdk_interactiveform.cpp
@@ -433,7 +433,7 @@
   if (!m_pInteractiveForm->CheckRequiredFields(nullptr, true))
     return false;
 
-  return SubmitForm(sDestination, false);
+  return SubmitForm(sDestination);
 }
 
 bool CPDFSDK_InteractiveForm::SubmitFields(
@@ -463,8 +463,7 @@
   return pFDF ? pFDF->WriteToString() : ByteString();
 }
 
-bool CPDFSDK_InteractiveForm::SubmitForm(const WideString& sDestination,
-                                         bool bUrlEncoded) {
+bool CPDFSDK_InteractiveForm::SubmitForm(const WideString& sDestination) {
   if (sDestination.IsEmpty())
     return false;
 
@@ -479,9 +478,6 @@
 
   std::vector<uint8_t, FxAllocAllocator<uint8_t>> buffer(fdfBuffer.begin(),
                                                          fdfBuffer.end());
-  if (bUrlEncoded && !FDFToURLEncodedData(&buffer))
-    return false;
-
   m_pFormFillEnv->SubmitForm(buffer, sDestination);
   return true;
 }

fpdfsdk/cpdfsdk_interactiveform.h

diff --git a/fpdfsdk/cpdfsdk_interactiveform.h b/fpdfsdk/cpdfsdk_interactiveform.h
index c0da74b..d4c5bda 100644
--- a/fpdfsdk/cpdfsdk_interactiveform.h
+++ b/fpdfsdk/cpdfsdk_interactiveform.h
@@ -76,7 +76,7 @@
                     const std::vector<CPDF_FormField*>& fields,
                     bool bIncludeOrExclude,
                     bool bUrlEncoded);
-  bool SubmitForm(const WideString& sDestination, bool bUrlEncoded);
+  bool SubmitForm(const WideString& sDestination);
   ByteString ExportFormToFDFTextBuf();
   ByteString ExportFieldsToFDFTextBuf(
       const std::vector<CPDF_FormField*>& fields,

fxjs/cjs_document.cpp

diff --git a/fxjs/cjs_document.cpp b/fxjs/cjs_document.cpp
index 573a114..91f6eb5 100644
--- a/fxjs/cjs_document.cpp
+++ b/fxjs/cjs_document.cpp
@@ -606,7 +606,7 @@
   if (pRuntime->GetArrayLength(aFields) == 0 && bEmpty) {
     if (pPDFForm->CheckRequiredFields(nullptr, true)) {
       pRuntime->BeginBlock();
-      GetSDKInteractiveForm()->SubmitForm(strURL, false);
+      GetSDKInteractiveForm()->SubmitForm(strURL);
       pRuntime->EndBlock();
     }
     return CJS_Result::Success();