commit c1c3819a8b357e1a65db07be1100cc3a82f63192
author Tom Sepez <tsepez@chromium.org> Mon May 10 20:06:46 2021 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon May 10 20:06:46 2021 +0000
tree 2baf837b15a6042066531d530144fab5f4247b4c
parent 693d552fa9021d158e2a1512982d9fcd2b57afc8

Replace some hex constants in cpdf_interactiveform.cpp

Equivalent symbolic constants already exist in form_flags.h

Change-Id: I35034db32877a4422e77cf84e2a640c2738291bd
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/80272
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfdoc/cpdf_interactiveform.cpp

diff --git a/core/fpdfdoc/cpdf_interactiveform.cpp b/core/fpdfdoc/cpdf_interactiveform.cpp
index 5451f27..6d23bfb 100644
--- a/core/fpdfdoc/cpdf_interactiveform.cpp
+++ b/core/fpdfdoc/cpdf_interactiveform.cpp
@@ -11,6 +11,7 @@
 
 #include "build/build_config.h"
 #include "constants/form_fields.h"
+#include "constants/form_flags.h"
 #include "constants/stream_dict_common.h"
 #include "core/fpdfapi/font/cpdf_font.h"
 #include "core/fpdfapi/font/cpdf_fontencoding.h"
@@ -981,13 +982,13 @@
       continue;
 
     uint32_t dwFlags = pField->GetFieldFlags();
-    if (dwFlags & 0x04)
+    if (dwFlags & pdfium::form_flags::kNoExport)
       continue;
 
     if (bIncludeOrExclude != pdfium::Contains(fields, pField))
       continue;
 
-    if ((dwFlags & 0x02) != 0 &&
+    if ((dwFlags & pdfium::form_flags::kRequired) != 0 &&
         pField->GetDict()->GetStringFor(pdfium::form_fields::kV).IsEmpty()) {
       continue;
     }