commit c51e0a0f9b2fbaa9f2eb911ab71f0d76d0215a94
author Lei Zhang <thestig@chromium.org> Fri Aug 10 22:16:35 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Aug 10 22:16:35 2018 +0000
tree 8baf141b9a967bc0352b32c9c84277b493197138
parent 6ce3b34281786c2332fa6de81fe67f7f4b883602

Make the 4th parameter in CPDF_Form non-optional.

Instead, add a 3-parameter constructor that delegates to the 4-parameter
constructor.

Change-Id: Ied6c55360084ea26b07dbaa449bf155b5db182f0
Reviewed-on: https://pdfium-review.googlesource.com/39872
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/page/cpdf_form.cpp

diff --git a/core/fpdfapi/page/cpdf_form.cpp b/core/fpdfapi/page/cpdf_form.cpp
index ca24f85..8db0dff 100644
--- a/core/fpdfapi/page/cpdf_form.cpp
+++ b/core/fpdfapi/page/cpdf_form.cpp
@@ -15,6 +15,11 @@
 
 CPDF_Form::CPDF_Form(CPDF_Document* pDoc,
                      CPDF_Dictionary* pPageResources,
+                     CPDF_Stream* pFormStream)
+    : CPDF_Form(pDoc, pPageResources, pFormStream, nullptr) {}
+
+CPDF_Form::CPDF_Form(CPDF_Document* pDoc,
+                     CPDF_Dictionary* pPageResources,
                      CPDF_Stream* pFormStream,
                      CPDF_Dictionary* pParentResources)
     : CPDF_PageObjectHolder(pDoc, pFormStream->GetDict()) {

core/fpdfapi/page/cpdf_form.h

diff --git a/core/fpdfapi/page/cpdf_form.h b/core/fpdfapi/page/cpdf_form.h
index 155a6ae..63cc4a9 100644
--- a/core/fpdfapi/page/cpdf_form.h
+++ b/core/fpdfapi/page/cpdf_form.h
@@ -23,8 +23,11 @@
  public:
   CPDF_Form(CPDF_Document* pDocument,
             CPDF_Dictionary* pPageResources,
+            CPDF_Stream* pFormStream);
+  CPDF_Form(CPDF_Document* pDocument,
+            CPDF_Dictionary* pPageResources,
             CPDF_Stream* pFormStream,
-            CPDF_Dictionary* pParentResources = nullptr);
+            CPDF_Dictionary* pParentResources);
   ~CPDF_Form() override;
 
   void ParseContent(CPDF_AllStates* pGraphicStates,