commit ca632ea1c4bdee0f6268fc4ff37784b899b171d2
author Tom Sepez <tsepez@chromium.org> Thu Apr 15 17:17:43 2021 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Apr 15 17:17:43 2021 +0000
tree 3797e1422cd5ef8f68c338bc0b962e9651dc4763
parent c317e8f2a9d961bcbfba146c004a73ca58e40651

Remove uncalled CPWL_ScrollBar::SetNotifyForever()

Then remove always-true member m_bNotifyForever.

Change-Id: I2fc4b96ebd8c3d801a659bd5cadbcf14174c15a9
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/79450
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/pwl/cpwl_scroll_bar.cpp

diff --git a/fpdfsdk/pwl/cpwl_scroll_bar.cpp b/fpdfsdk/pwl/cpwl_scroll_bar.cpp
index b07f5c2..7ed8f8c 100644
--- a/fpdfsdk/pwl/cpwl_scroll_bar.cpp
+++ b/fpdfsdk/pwl/cpwl_scroll_bar.cpp
@@ -433,10 +433,6 @@
 }
 
 void CPWL_ScrollBar::OnPosButtonLBUp(const CFX_PointF& point) {
-  if (m_bMouseDown) {
-    if (!m_bNotifyForever)
-      NotifyScrollWindow();
-  }
   m_bMouseDown = false;
 }
 
@@ -461,8 +457,7 @@
       if (!MovePosButton(true))
         return;
 
-      if (m_bNotifyForever)
-        NotifyScrollWindow();
+      NotifyScrollWindow();
     }
   }
 }

fpdfsdk/pwl/cpwl_scroll_bar.h

diff --git a/fpdfsdk/pwl/cpwl_scroll_bar.h b/fpdfsdk/pwl/cpwl_scroll_bar.h
index 805df52..ec8d367 100644
--- a/fpdfsdk/pwl/cpwl_scroll_bar.h
+++ b/fpdfsdk/pwl/cpwl_scroll_bar.h
@@ -114,7 +114,6 @@
   void OnTimerFired() override;
 
   float GetScrollBarWidth() const;
-  void SetNotifyForever(bool bForever) { m_bNotifyForever = bForever; }
 
  private:
   void SetScrollRange(float fMin, float fMax, float fClientWidth);
@@ -151,7 +150,6 @@
   PWL_SCROLL_PRIVATEDATA m_sData;
   bool m_bMouseDown = false;
   bool m_bMinOrMax = false;
-  bool m_bNotifyForever = true;
   float m_nOldPos = 0.0f;
   float m_fOldPosButton = 0.0f;
 };