commit cee39e6e90c219cc91f2c94a912a06977f4461a0
author Lei Zhang <thestig@chromium.org> Mon Nov 13 18:35:23 2017 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Nov 13 18:35:23 2017 +0000
tree 040d70270e5ff43e67383d745c2fcf2b57ec8f5e
parent 9fa5036245c34ce8c420531c5b02e699a861bc18

Check first page number in IsLinearizedHeaderValid().

This should allow https://pdfium-review.googlesource.com/15770 to safely
reland.

BUG=chromium:781529

Change-Id: Id0c1bde3280fb72125d8e74751b9a1cb35302b6f
Reviewed-on: https://pdfium-review.googlesource.com/18170
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/parser/cpdf_linearized_header.cpp

diff --git a/core/fpdfapi/parser/cpdf_linearized_header.cpp b/core/fpdfapi/parser/cpdf_linearized_header.cpp
index 3251a5e..994d69f 100644
--- a/core/fpdfapi/parser/cpdf_linearized_header.cpp
+++ b/core/fpdfapi/parser/cpdf_linearized_header.cpp
@@ -7,6 +7,7 @@
 #include "core/fpdfapi/parser/cpdf_linearized_header.h"
 
 #include <algorithm>
+#include <limits>
 #include <utility>
 
 #include "core/fpdfapi/parser/cpdf_array.h"
@@ -18,6 +19,7 @@
 namespace {
 
 constexpr FX_FILESIZE kLinearizedHeaderOffset = 9;
+constexpr size_t kMaxInt = static_cast<size_t>(std::numeric_limits<int>::max());
 
 template <class T>
 bool IsValidNumericDictionaryValue(const CPDF_Dictionary* pDict,
@@ -39,6 +41,8 @@
                              FX_FILESIZE file_size) {
   ASSERT(header);
   return header->GetFileSize() == file_size &&
+         static_cast<int>(header->GetFirstPageNo()) >= 0 &&
+         header->GetFirstPageNo() < kMaxInt &&
          header->GetMainXRefTableFirstEntryOffset() < file_size &&
          header->GetPageCount() > 0 &&
          header->GetFirstPageEndOffset() < file_size &&