commit cf705715c5311057933ac03b395d9ea75b6f0660
author Dan Sinclair <dsinclair@chromium.org> Sat Nov 04 01:34:07 2017 +0000
committer Chromium commit bot <commit-bot@chromium.org> Sat Nov 04 01:34:07 2017 +0000
tree 6ed7800850bd707b66bdb3a4acb5c4206421dbdc
parent 6fa9707e5db5454ab5ea1a8349d9e1d7cf2b175c

Remove default values from CXFA_Node::{Remove|Insert|Item}

This CL removes the default values and inlines into the call sites as
needed.

Change-Id: I8ba6acfc99b5db508ce8711108e0676465eda47b
Reviewed-on: https://pdfium-review.googlesource.com/17670
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fxjs/cjx_node.cpp

diff --git a/fxjs/cjx_node.cpp b/fxjs/cjx_node.cpp
index 17553c9..dc32e20 100644
--- a/fxjs/cjx_node.cpp
+++ b/fxjs/cjx_node.cpp
@@ -378,7 +378,7 @@
         break;
       }
       if (pRemoveInstance->GetNameHash() == dInstanceNameHash) {
-        GetXFANode()->RemoveItem(pRemoveInstance);
+        GetXFANode()->RemoveItem(pRemoveInstance, true);
         iCount--;
       }
     }
@@ -2510,7 +2510,7 @@
     return;
   }
   CXFA_Node* pRemoveInstance = GetXFANode()->GetItem(iIndex);
-  GetXFANode()->RemoveItem(pRemoveInstance);
+  GetXFANode()->RemoveItem(pRemoveInstance, true);
   CXFA_FFNotify* pNotify = GetDocument()->GetNotify();
   if (pNotify) {
     for (int32_t i = iIndex; i < iCount - 1; i++) {

xfa/fxfa/parser/cxfa_node.h

diff --git a/xfa/fxfa/parser/cxfa_node.h b/xfa/fxfa/parser/cxfa_node.h
index 01f9b3d..d8472eb 100644
--- a/xfa/fxfa/parser/cxfa_node.h
+++ b/xfa/fxfa/parser/cxfa_node.h
@@ -63,11 +63,11 @@
   CXFA_Node* CreateInstance(bool bDataMerge);
   int32_t GetCount();
   CXFA_Node* GetItem(int32_t iIndex);
-  void RemoveItem(CXFA_Node* pRemoveInstance, bool bRemoveDataBinding = true);
+  void RemoveItem(CXFA_Node* pRemoveInstance, bool bRemoveDataBinding);
   void InsertItem(CXFA_Node* pNewInstance,
                   int32_t iPos,
-                  int32_t iCount = -1,
-                  bool bMoveDataBindingNodes = true);
+                  int32_t iCount,
+                  bool bMoveDataBindingNodes);
 
   bool IsInitialized() const { return HasFlag(XFA_NodeFlag_Initialized); }
   bool IsOwnXMLNode() const { return HasFlag(XFA_NodeFlag_OwnXMLNode); }