commit 77be04971c130cadbbdba04814f3d77ef25548bc
author npm <npm@chromium.org> Tue Aug 30 15:56:24 2016 -0700
committer Commit bot <commit-bot@chromium.org> Tue Aug 30 15:56:24 2016 -0700
tree ffa1f11e5196708fa53158a7061c14cc486fcfc6
parent 8c54182aba447f7fbd6e763a559bec99ab996613

Clean up CPDF_CMap declaration

- Removed unused methods
- Friendship with CPDF_PathManager is not needed
- Protected may be changed to private

Review-Url: https://codereview.chromium.org/2292023003

core/fpdfapi/fpdf_font/font_int.h

diff --git a/core/fpdfapi/fpdf_font/font_int.h b/core/fpdfapi/fpdf_font/font_int.h
index c1e2f75..a09bb6b 100644
--- a/core/fpdfapi/fpdf_font/font_int.h
+++ b/core/fpdfapi/fpdf_font/font_int.h
@@ -142,20 +142,17 @@
                          const FX_CHAR* name,
                          FX_BOOL bPromptCJK);
   FX_BOOL LoadEmbedded(const uint8_t* pData, uint32_t dwSize);
-  void Release();
 
   FX_BOOL IsLoaded() const;
   FX_BOOL IsVertWriting() const;
   uint16_t CIDFromCharCode(uint32_t charcode) const;
-  uint32_t CharCodeFromCID(uint16_t CID) const;
   int GetCharSize(uint32_t charcode) const;
   uint32_t GetNextChar(const FX_CHAR* pString, int nStrLen, int& offset) const;
   int CountChar(const FX_CHAR* pString, int size) const;
   int AppendChar(FX_CHAR* str, uint32_t charcode) const;
 
- protected:
+ private:
   friend class CPDF_CMapParser;
-  friend class CPDF_CMapManager;
   friend class CPDF_CIDFont;
 
   CFX_ByteString m_PredefinedCMap;

core/fpdfapi/fpdf_font/fpdf_font_cid.cpp

diff --git a/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp
index cfcac36..d8cada7 100644
--- a/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp
+++ b/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp
@@ -518,11 +518,6 @@
   FX_Free(m_pAddMapping);
   FX_Free(m_pLeadingBytes);
 }
-void CPDF_CMap::Release() {
-  if (m_PredefinedCMap.IsEmpty()) {
-    delete this;
-  }
-}
 
 FX_BOOL CPDF_CMap::IsLoaded() const {
   return m_bLoaded;