| commit | d0cfb8cc152321f552a9d7c9754e9f05e3352e75 | [log] [tgz] |
|---|---|---|
| author | Lei Zhang <thestig@chromium.org> | Sat Feb 25 00:33:40 2017 -0800 |
| committer | Lei Zhang <thestig@chromium.org> | Mon Feb 27 19:06:20 2017 +0000 |
| tree | 4db4ff78ae610cb22a94621b4e3deae0d4415ee8 | |
| parent | c83d4758ef287716b0eabcae1775b50fd5cefa2d [diff] |
M57: Use container with stable iterator for m_Icons. The container may grow while it is being traversed in JS. BUG=691371 Change-Id: I73ee536458697267c69e6c3ada96e28546d11a4e Reviewed-on: https://pdfium-review.googlesource.com/2690 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> (cherry picked from commit 9e41d0461d175410f6ea7573e729dc1ae14e846d) Change-Id: I458e3e581616f10b157d118c60730df8324992d2 Reviewed-on: https://pdfium-review.googlesource.com/2842 Reviewed-by: dsinclair <dsinclair@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
diff --git a/fpdfsdk/javascript/Document.h b/fpdfsdk/javascript/Document.h index 227c428..7786c77 100644 --- a/fpdfsdk/javascript/Document.h +++ b/fpdfsdk/javascript/Document.h
@@ -288,7 +288,7 @@ CPDFSDK_FormFillEnvironment::ObservedPtr m_pFormFillEnv; CFX_WideString m_cwBaseURL; std::list<std::unique_ptr<CJS_DelayData>> m_DelayData; - std::vector<std::unique_ptr<IconElement>> m_Icons; + std::list<std::unique_ptr<IconElement>> m_Icons; // For iterator stability. bool m_bDelay; };