commit d1b54c3a80d04b447846d65dac63b4827269c46b
author Samuel Groß <saelo@chromium.org> Mon May 09 20:52:49 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 09 20:52:49 2022 +0000
tree fdb57d9a9b76fe034cb0009585d5dd99cdc1a460
parent 341d6adac1f4a8ff0d68a4da350b7c487807ef0d

Initialize the V8 Sandbox if it is enabled

The sandbox must be initialized before initializing V8.

Bug: v8:10391
Change-Id: Ia4c198b865c13c97d1c3c761c6ca948c903ac388
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93510
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

samples/simple_with_v8.cc

diff --git a/samples/simple_with_v8.cc b/samples/simple_with_v8.cc
index e4081fb..8b37c72 100644
--- a/samples/simple_with_v8.cc
+++ b/samples/simple_with_v8.cc
@@ -20,6 +20,9 @@
   v8::V8::InitializeExternalStartupData(argv[0]);
   v8::Platform* platform = v8::platform::NewDefaultPlatform().release();
   v8::V8::InitializePlatform(platform);
+#ifdef V8_SANDBOX
+  v8::V8::InitializeSandbox();
+#endif
   v8::V8::Initialize();
 
   v8::Isolate::CreateParams params;

testing/v8_initializer.cpp

diff --git a/testing/v8_initializer.cpp b/testing/v8_initializer.cpp
index b6499db..5dcb2bd 100644
--- a/testing/v8_initializer.cpp
+++ b/testing/v8_initializer.cpp
@@ -80,6 +80,9 @@
   static const char kAdditionalV8Flags[] = "--predictable --expose-gc";
   v8::V8::SetFlagsFromString(kAdditionalV8Flags);
 
+#ifdef V8_SANDBOX
+  v8::V8::InitializeSandbox();
+#endif
   v8::V8::Initialize();
   return platform;
 }