commit d2c9084907e8d678d448cd014ca415120814f0c0
author Lei Zhang <thestig@chromium.org> Tue Jun 02 19:05:07 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Jun 02 19:05:07 2020 +0000
tree 83b78033050b4379aea6cfbb20cd4a1cf88ddcdb
parent 15b545f6f8233f06d752ebf83673324278195c49

Flip a conditional in CPDF_RenderStatus::ProcessType3Text().

Remove a negation so an if-else statement does not have a double
negative in the else case.

Change-Id: Idac781aa205f926782e1156003d561b42a2a2384
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/70271
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>

core/fpdfapi/render/cpdf_renderstatus.cpp

diff --git a/core/fpdfapi/render/cpdf_renderstatus.cpp b/core/fpdfapi/render/cpdf_renderstatus.cpp
index 060d881..71e9b7c 100644
--- a/core/fpdfapi/render/cpdf_renderstatus.cpp
+++ b/core/fpdfapi/render/cpdf_renderstatus.cpp
@@ -1050,7 +1050,17 @@
         m_pDevice->SetDIBits(bitmap_device.GetBitmap(), rect.left, rect.top);
       }
     } else if (pType3Char->GetBitmap()) {
-      if (!m_bPrint) {
+      if (m_bPrint) {
+        CFX_Matrix image_matrix = pType3Char->matrix() * matrix;
+        CPDF_ImageRenderer renderer;
+        if (renderer.Start(this, pType3Char->GetBitmap(), fill_argb, 255,
+                           image_matrix, FXDIB_ResampleOptions(), false,
+                           BlendMode::kNormal)) {
+          renderer.Continue(nullptr);
+        }
+        if (!renderer.GetResult())
+          return false;
+      } else {
         CPDF_Document* pDoc = pType3Font->GetDocument();
         RetainPtr<CPDF_Type3Cache> pCache =
             CPDF_DocRenderData::FromDocument(pDoc)->GetCachedType3(pType3Font);
@@ -1079,16 +1089,6 @@
           glyphs[iChar].m_pGlyph = pBitmap;
           glyphs[iChar].m_Origin = origin;
         }
-      } else {
-        CFX_Matrix image_matrix = pType3Char->matrix() * matrix;
-        CPDF_ImageRenderer renderer;
-        if (renderer.Start(this, pType3Char->GetBitmap(), fill_argb, 255,
-                           image_matrix, FXDIB_ResampleOptions(), false,
-                           BlendMode::kNormal)) {
-          renderer.Continue(nullptr);
-        }
-        if (!renderer.GetResult())
-          return false;
       }
     }
   }