commit d7e911e6ec17c619981603e77f33432bb9f00b89
author Miklos Vajna <vmiklos@collabora.co.uk> Mon Jun 28 19:58:54 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 28 19:58:54 2021 +0000
tree f13d1ed3b9c7d7518b57f905e407032ec904bd06
parent d06b0fb4213f56e44b9312916fbb91dd6eea4e19

FPDFTextObj_GetFontName: improve type of the output buffer

This was untyped void*, but in practice we always write at as a char*,
make that explicit.

Change-Id: I4e31e7580a0a9bde99d41d8e00f679927191a6ef
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/82670
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_edittext.cpp

diff --git a/fpdfsdk/fpdf_edittext.cpp b/fpdfsdk/fpdf_edittext.cpp
index fde0b40..da3d092 100644
--- a/fpdfsdk/fpdf_edittext.cpp
+++ b/fpdfsdk/fpdf_edittext.cpp
@@ -547,7 +547,7 @@
 
 FPDF_EXPORT unsigned long FPDF_CALLCONV
 FPDFTextObj_GetFontName(FPDF_PAGEOBJECT text,
-                        void* buffer,
+                        char* buffer,
                         unsigned long length) {
   CPDF_TextObject* pTextObj = CPDFTextObjectFromFPDFPageObject(text);
   if (!pTextObj)

public/fpdf_edit.h

diff --git a/public/fpdf_edit.h b/public/fpdf_edit.h
index 2290cd5..563ed02 100644
--- a/public/fpdf_edit.h
+++ b/public/fpdf_edit.h
@@ -1241,7 +1241,7 @@
 // will not be modified.
 FPDF_EXPORT unsigned long FPDF_CALLCONV
 FPDFTextObj_GetFontName(FPDF_PAGEOBJECT text,
-                        void* buffer,
+                        char* buffer,
                         unsigned long length);
 
 // Experimental API.