commit e158a00f38f2891a08937b426b853457b6b04219
author Lei Zhang <thestig@chromium.org> Fri Mar 29 17:16:03 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Mar 29 17:16:03 2019 +0000
tree 6bd3a3d93ddf3ae2e06bb0d0ba1bbba27a5f77ec
parent 28de1b3833636ca091da2180b6d335211edc2780

Rename SetValue() to SetFieldValue().

SetValue() is too generic and hard to search for.

Change-Id: Idfe4fe56909573ac1d7ef5db4b4b46cb58468d90
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52651
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxjs/cjs_field.cpp

diff --git a/fxjs/cjs_field.cpp b/fxjs/cjs_field.cpp
index 753094b..3250094 100644
--- a/fxjs/cjs_field.cpp
+++ b/fxjs/cjs_field.cpp
@@ -406,10 +406,10 @@
   }
 }
 
-void SetValue(CPDFSDK_FormFillEnvironment* pFormFillEnv,
-              const WideString& swFieldName,
-              int nControlIndex,
-              const std::vector<WideString>& strArray) {
+void SetFieldValue(CPDFSDK_FormFillEnvironment* pFormFillEnv,
+                   const WideString& swFieldName,
+                   int nControlIndex,
+                   const std::vector<WideString>& strArray) {
   ASSERT(pFormFillEnv);
   if (strArray.empty())
     return;
@@ -2154,7 +2154,8 @@
   if (m_bDelay) {
     AddDelay_WideStringArray(FP_VALUE, strArray);
   } else {
-    SetValue(m_pFormFillEnv.Get(), m_FieldName, m_nFormControlIndex, strArray);
+    SetFieldValue(m_pFormFillEnv.Get(), m_FieldName, m_nFormControlIndex,
+                  strArray);
   }
   return CJS_Result::Success();
 }
@@ -2651,8 +2652,8 @@
               pData->rect);
       break;
     case FP_VALUE:
-      SetValue(pFormFillEnv, pData->sFieldName, pData->nControlIndex,
-               pData->widestringarray);
+      SetFieldValue(pFormFillEnv, pData->sFieldName, pData->nControlIndex,
+                    pData->widestringarray);
       break;
     default:
       NOTREACHED();