commit e75538b44dc0afd1951a29d4574a8bdb11ca336f
author Lei Zhang <thestig@chromium.org> Wed Dec 20 19:33:20 2017 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Dec 20 19:33:20 2017 +0000
tree dc9c001acd600eb2c2e1e02321ffda580d273f91
parent fbeb04b695541935569611bc58a5dce0f2e6aed6

Fix nits in JSEmbedderTest.

Change-Id: Ib03ee28f7a52cd5aa53c315402141b3b6cff5e7d
Reviewed-on: https://pdfium-review.googlesource.com/21892
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

testing/js_embedder_test.cpp

diff --git a/testing/js_embedder_test.cpp b/testing/js_embedder_test.cpp
index 064a961..e9eb70d 100644
--- a/testing/js_embedder_test.cpp
+++ b/testing/js_embedder_test.cpp
@@ -3,11 +3,12 @@
 // found in the LICENSE file.
 
 #include "testing/js_embedder_test.h"
+
 #include "third_party/base/ptr_util.h"
 
 JSEmbedderTest::JSEmbedderTest()
-    : m_pArrayBufferAllocator(new FXJS_ArrayBufferAllocator),
-      m_pIsolate(nullptr) {}
+    : m_pArrayBufferAllocator(pdfium::MakeUnique<FXJS_ArrayBufferAllocator>()) {
+}
 
 JSEmbedderTest::~JSEmbedderTest() {}
 

testing/js_embedder_test.h

diff --git a/testing/js_embedder_test.h b/testing/js_embedder_test.h
index fbec0ea..1f27dbe 100644
--- a/testing/js_embedder_test.h
+++ b/testing/js_embedder_test.h
@@ -6,7 +6,6 @@
 #define TESTING_JS_EMBEDDER_TEST_H_
 
 #include <memory>
-#include <vector>
 
 #include "fxjs/fxjs_v8.h"
 #include "testing/embedder_test.h"
@@ -25,7 +24,7 @@
 
  private:
   std::unique_ptr<FXJS_ArrayBufferAllocator> m_pArrayBufferAllocator;
-  v8::Isolate* m_pIsolate;
+  v8::Isolate* m_pIsolate = nullptr;
   std::unique_ptr<CFXJS_Engine> m_Engine;
 };