commit e9910aca73053d9cc23cbb7c461d2f3a7a148876
author Tom Sepez <tsepez@chromium.org> Fri Jun 18 17:08:54 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 18 17:08:54 2021 +0000
tree b9ff7c327b0a3bb769db3dd6a1c14a6885ced13d
parent d23a900fb4827b795adb71dfcf7b32fd809bc323

Remove always-false argument from CPLW_EditImpl::SetAutoScroll()

Change-Id: If9d8f9b4116193cf1ce627b73e0b23cac7a0c08f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/82194
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fpdfsdk/pwl/cpwl_edit.cpp

diff --git a/fpdfsdk/pwl/cpwl_edit.cpp b/fpdfsdk/pwl/cpwl_edit.cpp
index 8478511..513ee55 100644
--- a/fpdfsdk/pwl/cpwl_edit.cpp
+++ b/fpdfsdk/pwl/cpwl_edit.cpp
@@ -142,7 +142,7 @@
   m_pEditImpl->SetMultiLine(HasFlag(PES_MULTILINE), false);
   m_pEditImpl->SetAutoReturn(HasFlag(PES_AUTORETURN), false);
   m_pEditImpl->SetAutoFontSize(HasFlag(PWS_AUTOFONTSIZE), false);
-  m_pEditImpl->SetAutoScroll(HasFlag(PES_AUTOSCROLL), false);
+  m_pEditImpl->SetAutoScroll(HasFlag(PES_AUTOSCROLL));
   m_pEditImpl->EnableUndo(HasFlag(PES_UNDO));
 
   if (HasFlag(PES_TEXTOVERFLOW)) {

fpdfsdk/pwl/cpwl_edit_impl.cpp

diff --git a/fpdfsdk/pwl/cpwl_edit_impl.cpp b/fpdfsdk/pwl/cpwl_edit_impl.cpp
index 705678e..5be9483 100644
--- a/fpdfsdk/pwl/cpwl_edit_impl.cpp
+++ b/fpdfsdk/pwl/cpwl_edit_impl.cpp
@@ -783,10 +783,8 @@
   Paint();
 }
 
-void CPWL_EditImpl::SetAutoScroll(bool bAuto, bool bPaint) {
+void CPWL_EditImpl::SetAutoScroll(bool bAuto) {
   m_bEnableScroll = bAuto;
-  if (bPaint)
-    Paint();
 }
 
 void CPWL_EditImpl::SetTextOverflow(bool bAllowed, bool bPaint) {

fpdfsdk/pwl/cpwl_edit_impl.h

diff --git a/fpdfsdk/pwl/cpwl_edit_impl.h b/fpdfsdk/pwl/cpwl_edit_impl.h
index 8b2bb56..f1e3bb0 100644
--- a/fpdfsdk/pwl/cpwl_edit_impl.h
+++ b/fpdfsdk/pwl/cpwl_edit_impl.h
@@ -81,7 +81,7 @@
   void SetMultiLine(bool bMultiLine, bool bPaint);
   void SetAutoReturn(bool bAuto, bool bPaint);
   void SetAutoFontSize(bool bAuto, bool bPaint);
-  void SetAutoScroll(bool bAuto, bool bPaint);
+  void SetAutoScroll(bool bAuto);
   void SetFontSize(float fFontSize);
   void SetTextOverflow(bool bAllowed, bool bPaint);
   void OnMouseDown(const CFX_PointF& point, bool bShift, bool bCtrl);