commit f429179cf75f6eaa8272585209ddc801df6823fa
author Lei Zhang <thestig@chromium.org> Fri Apr 12 00:04:30 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Apr 12 00:04:30 2019 +0000
tree becbb2f5c83570be94f7cd2de897f1dc44707fbc
parent 945599920ef91579e19f5249bef0e22e08fad334

Remove dead code in CPDF_Annot.

|m_pAnnotDict| is never nullptr.

Change-Id: I32f158ad8800e3d539136b166a54b90957d176d7
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/53250
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfdoc/cpdf_annot.cpp

diff --git a/core/fpdfdoc/cpdf_annot.cpp b/core/fpdfdoc/cpdf_annot.cpp
index 9c7649c..04029ac 100644
--- a/core/fpdfdoc/cpdf_annot.cpp
+++ b/core/fpdfdoc/cpdf_annot.cpp
@@ -154,21 +154,14 @@
 }
 
 CFX_FloatRect CPDF_Annot::RectForDrawing() const {
-  if (!m_pAnnotDict)
-    return CFX_FloatRect();
-
   bool bShouldUseQuadPointsCoords =
       m_bIsTextMarkupAnnotation && m_bHasGeneratedAP;
   if (bShouldUseQuadPointsCoords)
     return BoundingRectFromQuadPoints(m_pAnnotDict.Get());
-
   return m_pAnnotDict->GetRectFor(pdfium::annotation::kRect);
 }
 
 CFX_FloatRect CPDF_Annot::GetRect() const {
-  if (!m_pAnnotDict)
-    return CFX_FloatRect();
-
   CFX_FloatRect rect = RectForDrawing();
   rect.Normalize();
   return rect;