Fix various lint errors.
Change-Id: I405fe70627376c87a7307f109f313214cf704c50
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69813
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/core/fdrm/fx_crypt_unittest.cpp b/core/fdrm/fx_crypt_unittest.cpp
index de76cd0..8b6fd7d 100644
--- a/core/fdrm/fx_crypt_unittest.cpp
+++ b/core/fdrm/fx_crypt_unittest.cpp
@@ -4,8 +4,10 @@
#include "core/fdrm/fx_crypt.h"
+#include <algorithm>
#include <memory>
#include <string>
+#include <vector>
#include "core/fxcrt/fx_memory.h"
#include "testing/gtest/include/gtest/gtest.h"
diff --git a/core/fpdfdoc/cpdf_icon.h b/core/fpdfdoc/cpdf_icon.h
index 519fcda..d9c4986 100644
--- a/core/fpdfdoc/cpdf_icon.h
+++ b/core/fpdfdoc/cpdf_icon.h
@@ -15,7 +15,7 @@
class CPDF_Icon final {
public:
- CPDF_Icon(CPDF_Stream* pStream);
+ explicit CPDF_Icon(CPDF_Stream* pStream);
~CPDF_Icon();
CFX_SizeF GetImageSize() const;
diff --git a/core/fxge/cfx_folderfontinfo_unittest.cpp b/core/fxge/cfx_folderfontinfo_unittest.cpp
index e3626da..0e7e08b 100644
--- a/core/fxge/cfx_folderfontinfo_unittest.cpp
+++ b/core/fxge/cfx_folderfontinfo_unittest.cpp
@@ -4,17 +4,21 @@
#include "core/fxge/cfx_folderfontinfo.h"
+#include <utility>
+
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/base/ptr_util.h"
#include "third_party/base/stl_util.h"
namespace {
+
constexpr char kArial[] = "Arial";
constexpr char kTimesNewRoman[] = "TimesNewRoman";
constexpr char kSymbol[] = "Symbol";
constexpr char kBookshelfSymbol7[] = "Bookshelf Symbol 7";
constexpr char kCalibri[] = "Calibri";
constexpr char kBookshelf[] = "Bookshelf";
+
} // namespace
class CFX_FolderFontInfoTest : public ::testing::Test {
diff --git a/core/fxge/win32/fx_win32_dib.cpp b/core/fxge/win32/fx_win32_dib.cpp
index 7b349e1..48c6fc8 100644
--- a/core/fxge/win32/fx_win32_dib.cpp
+++ b/core/fxge/win32/fx_win32_dib.cpp
@@ -6,6 +6,8 @@
#include <windows.h>
+#include <vector>
+
#include "core/fxcrt/fx_memory_wrappers.h"
#include "core/fxcrt/fx_system.h"
#include "core/fxge/cfx_gemodule.h"
diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index cd0bb9d..3e96b99 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -2789,7 +2789,6 @@
#define MAYBE_AddMarkCompressedStream AddMarkCompressedStream
#endif
TEST_F(FPDFEditEmbedderTest, MAYBE_AddMarkCompressedStream) {
-
// Load document with some text in a compressed stream.
EXPECT_TRUE(OpenDocument("hello_world_compressed_stream.pdf"));
FPDF_PAGE page = LoadPage(0);
diff --git a/fpdfsdk/fpdf_sysfontinfo_embeddertest.cpp b/fpdfsdk/fpdf_sysfontinfo_embeddertest.cpp
index 61cec04..a1c1510 100644
--- a/fpdfsdk/fpdf_sysfontinfo_embeddertest.cpp
+++ b/fpdfsdk/fpdf_sysfontinfo_embeddertest.cpp
@@ -4,6 +4,8 @@
#include "public/fpdf_sysfontinfo.h"
+#include <set>
+
#include "testing/embedder_test.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/base/stl_util.h"
diff --git a/fxjs/xfa/cfxjse_formcalc_context.cpp b/fxjs/xfa/cfxjse_formcalc_context.cpp
index c59421d..815c5a4 100644
--- a/fxjs/xfa/cfxjse_formcalc_context.cpp
+++ b/fxjs/xfa/cfxjse_formcalc_context.cpp
@@ -4271,7 +4271,6 @@
szResult << '\0';
info.GetReturnValue().Set(fxv8::NewStringHelper(
info.GetIsolate(), ByteStringView(szResult.str().c_str())));
- ;
}
// static
