commit f4d4feed12f64b600a8d71975eae67dcfeb77192
author Lei Zhang <thestig@chromium.org> Wed Dec 04 18:06:13 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Dec 04 18:06:13 2019 +0000
tree 76337c47ca63377cc34e988aa5563dd949ffed23
parent 38f725fb445ad4da15229208005d768fafc48a90

Stop manually setting -Wshadow.

Use //build/config/compiler:noshadowing instead.

Change-Id: I9be2692daea967f57a49768206bd9a83da9b0e57
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63090
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index ec0a94f..f27a2f4 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -83,11 +83,9 @@
   configs = [
     ":pdfium_common_config",
     ":pdfium_public_config",
+    "//build/config/compiler:noshadowing",
   ]
   defines = []
-  if (is_clang) {
-    cflags += [ "-Wshadow" ]
-  }
   if (is_linux) {
     if (current_cpu == "x64") {
       defines += [ "_FX_CPU_=_FX_X64_" ]