commit f61c6b34905b593431346026ba15255a2c559b45
author Tom Sepez <tsepez@chromium.org> Tue May 25 19:17:01 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 25 19:17:01 2021 +0000
tree 1c7e449ca7e9f46e99bc3a15310361ba3c251e75
parent 892acec62762919a545122af0a11947e20cd10b7

Use more informative argument type in GetFirstPropertyWithFlag()

Change-Id: I37b7ed59a180ea9c31259a9be174a2a88fb51a14
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/80992
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

xfa/fxfa/parser/cxfa_node.cpp

diff --git a/xfa/fxfa/parser/cxfa_node.cpp b/xfa/fxfa/parser/cxfa_node.cpp
index b8ff3fb..0e93b36 100644
--- a/xfa/fxfa/parser/cxfa_node.cpp
+++ b/xfa/fxfa/parser/cxfa_node.cpp
@@ -1149,7 +1149,8 @@
   return pNewNode;
 }
 
-Optional<XFA_Element> CXFA_Node::GetFirstPropertyWithFlag(uint8_t flag) const {
+Optional<XFA_Element> CXFA_Node::GetFirstPropertyWithFlag(
+    XFA_PropertyFlagMask flag) const {
   for (const auto& prop : m_Properties) {
     if (prop.flags & flag)
       return prop.property;

xfa/fxfa/parser/cxfa_node.h

diff --git a/xfa/fxfa/parser/cxfa_node.h b/xfa/fxfa/parser/cxfa_node.h
index 455181d..3a12edc 100644
--- a/xfa/fxfa/parser/cxfa_node.h
+++ b/xfa/fxfa/parser/cxfa_node.h
@@ -435,7 +435,8 @@
   bool HasFlag(XFA_NodeFlag dwFlag) const;
   const PropertyData* GetPropertyData(XFA_Element property) const;
   const AttributeData* GetAttributeData(XFA_Attribute attr) const;
-  Optional<XFA_Element> GetFirstPropertyWithFlag(uint8_t flag) const;
+  Optional<XFA_Element> GetFirstPropertyWithFlag(
+      XFA_PropertyFlagMask flag) const;
   void OnRemoved(bool bNotify) const;
   Optional<void*> GetDefaultValue(XFA_Attribute attr,
                                   XFA_AttributeType eType) const;