commit fbd4d6854df215b049434ef404400862ca68a411
author Tom Sepez <tsepez@chromium.org> Fri Jun 11 23:49:17 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 11 23:49:17 2021 +0000
tree 0f5a5145610945b50a021346d5d5875b4cd8f6fb
parent d6aa5e5110f4885a7ec67241d69111a5d110f564

Statically assert PixelWeight is trivially destructible

Due to C-style variable-sizing tricks, these will never be
destroyed by C++.

Change-Id: Iaf43d163b24a5d7ad35e6aba791015df678189f4
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/81986
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fxge/dib/fx_dib.cpp

diff --git a/core/fxge/dib/fx_dib.cpp b/core/fxge/dib/fx_dib.cpp
index 2d50e83..315388b 100644
--- a/core/fxge/dib/fx_dib.cpp
+++ b/core/fxge/dib/fx_dib.cpp
@@ -7,12 +7,17 @@
 #include "core/fxge/dib/fx_dib.h"
 
 #include <tuple>
+#include <type_traits>
 #include <utility>
 
 #include "build/build_config.h"
 #include "core/fxcrt/fx_extension.h"
 #include "core/fxcrt/fx_safe_types.h"
 
+static_assert(
+    std::is_trivially_destructible<PixelWeight>::value,
+    "PixelWeight storage may be re-used without invoking its destructor");
+
 #if defined(OS_WIN)
 static_assert(sizeof(FX_COLORREF) == sizeof(COLORREF),
               "FX_COLORREF vs. COLORREF mismatch");