commit fd8dfdfc54e2af0749663e9e0c3c2ef24b04f59e
author Dan Elphick <delphick@chromium.org> Thu Jul 26 09:57:26 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Jul 26 09:57:26 2018 +0000
tree 2bc702ba7f33209901c3f3f31fe3a9d239a89778
parent 893e730d5c4d58fc67a5b335d5b7a601262f457e

Fix usage of deprecated V8 Value::ToString method

Value::ToString is deprecated since the Isolate is inferred from the
memory address of the object being converted to a string which will soon
not be reliable. As such this method will be removed in the very near
future.
Change-Id: I1e5a1a0464f2052cc3aa5eeb1ddbdb7b0a9222d3
Reviewed-on: https://pdfium-review.googlesource.com/38914
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>

fxjs/cjs_global.cpp

diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp
index efeef56..567d548 100644
--- a/fxjs/cjs_global.cpp
+++ b/fxjs/cjs_global.cpp
@@ -146,7 +146,8 @@
   ASSERT(property->IsString());
   JSSpecialPropQuery<CJS_Global>(
       "global",
-      v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),
+      v8::Local<v8::String>::New(info.GetIsolate(),
+                                 property->ToString(info.GetIsolate())),
       info);
 }
 
@@ -157,7 +158,8 @@
   ASSERT(property->IsString());
   JSSpecialPropGet<CJS_Global>(
       "global",
-      v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),
+      v8::Local<v8::String>::New(info.GetIsolate(),
+                                 property->ToString(info.GetIsolate())),
       info);
 }
 
@@ -169,7 +171,8 @@
   ASSERT(property->IsString());
   JSSpecialPropPut<CJS_Global>(
       "global",
-      v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),
+      v8::Local<v8::String>::New(info.GetIsolate(),
+                                 property->ToString(info.GetIsolate())),
       value, info);
 }
 
@@ -180,7 +183,8 @@
   ASSERT(property->IsString());
   JSSpecialPropDel<CJS_Global>(
       "global",
-      v8::Local<v8::String>::New(info.GetIsolate(), property->ToString()),
+      v8::Local<v8::String>::New(info.GetIsolate(),
+                                 property->ToString(info.GetIsolate())),
       info);
 }