commit ff0c8aa863540ede55087282fd5b71cdd51c9f13
author Tom Sepez <tsepez@chromium.org> Wed Nov 09 23:44:00 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 09 23:44:00 2022 +0000
tree d9c32294005a9922f3d5c9e4b9505e814c2d58f7
parent 868d94c694b82d207f77b3f8ed33f70f044be1a1

Remove needless multiplication by 1 in CPDF_Image::SetImage()

Change-Id: If9d7f901cdd1e390feb47bbba0f7bfee27da4d73
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/101010
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

core/fpdfapi/page/cpdf_image.cpp

diff --git a/core/fpdfapi/page/cpdf_image.cpp b/core/fpdfapi/page/cpdf_image.cpp
index 718abe8..48595a9 100644
--- a/core/fpdfapi/page/cpdf_image.cpp
+++ b/core/fpdfapi/page/cpdf_image.cpp
@@ -306,22 +306,16 @@
       src_buf += src_pitch;
     }
   } else {
-    int32_t src_offset = 0;
     for (int32_t row = 0; row < BitmapHeight; row++) {
       size_t dest_span_row_offset = dest_span_offset;
-      src_offset = row * src_pitch;
+      int32_t src_offset = row * src_pitch;
       for (int32_t column = 0; column < BitmapWidth; column++) {
-        float alpha = 1;
-        dest_span[dest_span_row_offset] =
-            static_cast<uint8_t>(src_buf[src_offset + 2] * alpha);
-        dest_span[dest_span_row_offset + 1] =
-            static_cast<uint8_t>(src_buf[src_offset + 1] * alpha);
-        dest_span[dest_span_row_offset + 2] =
-            static_cast<uint8_t>(src_buf[src_offset] * alpha);
+        dest_span[dest_span_row_offset] = src_buf[src_offset + 2];
+        dest_span[dest_span_row_offset + 1] = src_buf[src_offset + 1];
+        dest_span[dest_span_row_offset + 2] = src_buf[src_offset];
         dest_span_row_offset += 3;
         src_offset += bpp == 24 ? 3 : 4;
       }
-
       dest_span_offset += dest_pitch;
     }
   }