commit ff4d4525dbabba90f82b084004debd43dfeebdef
author Tom Sepez <tsepez@chromium.org> Wed May 11 18:50:15 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 11 18:50:15 2022 +0000
tree 0aee7febdbb0a2acdac7b592eeea4b0d86c9db2f
parent 0bd11f78b69d990331d7f4dad37d6fa34b08c3f9

Show that SetFillerNotify() is redundant in CPWL_Wnd sub-classes.

There's only one per form fill environment, and it is already set
in the CPWL_Wnd super-class.

Change-Id: Iee9133e58173584f608a64f173ac31da4b539679
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93610
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/pwl/cpwl_combo_box.cpp

diff --git a/fpdfsdk/pwl/cpwl_combo_box.cpp b/fpdfsdk/pwl/cpwl_combo_box.cpp
index 8c43da7..37127e7 100644
--- a/fpdfsdk/pwl/cpwl_combo_box.cpp
+++ b/fpdfsdk/pwl/cpwl_combo_box.cpp
@@ -461,6 +461,7 @@
 }
 
 void CPWL_ComboBox::SetFillerNotify(IPWL_FillerNotify* pNotify) {
+  CHECK_EQ(pNotify, GetCreationParams()->pFillerNotify);
   m_pFillerNotify = pNotify;
 
   if (m_pEdit)

fpdfsdk/pwl/cpwl_edit.h

diff --git a/fpdfsdk/pwl/cpwl_edit.h b/fpdfsdk/pwl/cpwl_edit.h
index 0656088..845f338 100644
--- a/fpdfsdk/pwl/cpwl_edit.h
+++ b/fpdfsdk/pwl/cpwl_edit.h
@@ -16,6 +16,7 @@
 #include "core/fxcrt/widestring.h"
 #include "fpdfsdk/pwl/cpwl_wnd.h"
 #include "fpdfsdk/pwl/ipwl_fillernotify.h"
+#include "third_party/base/check_op.h"
 
 class CPDF_Font;
 class CPWL_Caret;
@@ -96,6 +97,7 @@
                                         int32_t nCharArray);
 
   void SetFillerNotify(IPWL_FillerNotify* pNotify) {
+    CHECK_EQ(pNotify, GetCreationParams()->pFillerNotify);
     m_pFillerNotify = pNotify;
   }
 

fpdfsdk/pwl/cpwl_list_box.h

diff --git a/fpdfsdk/pwl/cpwl_list_box.h b/fpdfsdk/pwl/cpwl_list_box.h
index d72672a..f0df413 100644
--- a/fpdfsdk/pwl/cpwl_list_box.h
+++ b/fpdfsdk/pwl/cpwl_list_box.h
@@ -12,6 +12,7 @@
 #include "core/fxcrt/unowned_ptr.h"
 #include "fpdfsdk/pwl/cpwl_list_ctrl.h"
 #include "fpdfsdk/pwl/cpwl_wnd.h"
+#include "third_party/base/check_op.h"
 
 class IPWL_FillerNotify;
 
@@ -76,6 +77,7 @@
   CFX_FloatRect GetListRect() const;
 
   void SetFillerNotify(IPWL_FillerNotify* pNotify) {
+    CHECK_EQ(pNotify, GetCreationParams()->pFillerNotify);
     m_pFillerNotify = pNotify;
   }